Ensure vendor tree is transpiled when developing addon.
#274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default ember-cli updates a number of the "app trees" to be from `tests/dummy` when developing an addon locally. We do this for `app`, `styles`, `templates`, `public`, and `tests` trees (handled inside `lib/broccoli/ember-addon.js`). Unfortunately, we do **not** forward the apps `vendor` tree to `tests/dummy/`. This means that our addon's `treeForVendor` is called, but then subsequently _clobbered_ by the "apps" `vendor` tree (which is _literally the same tree_, but untranspiled). IMHO, this should be fixed in ember-cli upstream. I can't imagine anyone relying on this behavior intentionally...
|
I created ember-cli/ember-cli#7505 to track fixing in ember-cli itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default ember-cli updates a number of the "app trees" to be from
tests/dummywhen developing an addon locally. We do this forapp,styles,templates,public, andteststrees (handled insidelib/broccoli/ember-addon.js).Unfortunately, we do not forward the apps
vendortree totests/dummy/. This means that our addon'streeForVendoris called, but then subsequently clobbered by the "apps"vendortree (which is literally the same tree, but untranspiled).IMHO, this should be fixed in ember-cli upstream. I can't imagine anyone relying on this behavior intentionally...