Random cleanup... #238
Merged
Random cleanup... #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
reviewed
Nov 8, 2017
| `Ember.testing should be reset after test has completed. ${module}: ${name} did not reset Ember.testing` | ||
| `Ember.testing should be reset after test has completed. ${module}: ${ | ||
| name | ||
| } did not reset Ember.testing` |
There was a problem hiding this comment.
ugh... how is that "prettier"?! :-/
There was a problem hiding this comment.
Hehe. I felt the same way. Unfortunately I was getting trolled by ember-try using npm to install bower (which ultimately ended up forcing all packages to the latest version regardless of useYarn flag) so I couldn’t dig in to how to prevent this. 😢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.