Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import require (avoid using global require). #198

Merged
merged 1 commit into from
Mar 4, 2017
Merged

Import require (avoid using global require). #198

merged 1 commit into from
Mar 4, 2017

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Mar 4, 2017

Relying on global require calls causes issues in babel@6.

@rwjblue
Import require (avoid using global require).
b6c70b0 
Relying on global `require` calls causes issues in babel@6.
trentmwillis
trentmwillis approved these changes Mar 4, 2017
View reviewed changes
Copy link
Member

@trentmwillis trentmwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, didn't realize loader.js supported this (though seems obvious now).

@rwjblue rwjblue merged commit 455f9c1 into master Mar 4, 2017
@rwjblue rwjblue deleted the import-require branch March 10, 2017 17:09
@rwjblue rwjblue mentioned this pull request Apr 10, 2017
Closed
@Turbo87 Turbo87 mentioned this pull request May 7, 2017
Closed
@Turbo87 Turbo87 added the bug label Oct 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentmwillis trentmwillis trentmwillis approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rwjblue @trentmwillis @Turbo87