Remove usage of context
in moduleForComponent
.
#157
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
context
orcontroller
on anEmber.Component
was absolutely not supposed to work (ever), but this library worked around that to serve its own needs whenEmber.View
was deprecated and removed.This PR makes
moduleForComponent
work properly against canary (soon to be 2.7.0), by avoiding this archaic concept and simply tracking the thingsset
on the test context manually.