Make build-registry work correctly when ember-data addon is used #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
| resolutions: { | ||
| "ember": "release" | ||
| } |
There was a problem hiding this comment.
Hmm, I just realized that ember-try only works with bower dependencies for now. So I am not sure this config is really helpful to test the code path below 😔
rwjblue
added a commit
that referenced
this pull request
Jan 14, 2016
…mber-data-addon Make build-registry work correctly when ember-data addon is used
|
Thank you! I'll release shortly... |
|
@rwjblue just curious, do you have an ETA? Also will this have to kick off a release in ember-quint and ember-cli-qunit as well? Also, is there a reason ember data does not actually use these test helpers? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit for fix code goes to @rwjblue, I am merely the humble PR creator.
This addresses emberjs/data#4071.