Add wait helper.
#112
Merged
Add wait helper.
#112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👏 I think the stock integration test |
This allows component integration tests that need to deal with async
interactions to have an easy way to model their tests.
Example test (assuming the component does some async in an action
triggered by the button click):
```javascript
import { moduleForComponent, test } from 'ember-test-helpers';
import waitForPendingRunLoops from 'ember-test-helpers/wait';
test('it works when async exists in an event/action', function(assert) {
this.render('{{my-foo}}');
this.$('button').click();
return waitForPendingRunLoops()
.then(() => {
// assertions for after async behavior
});
});
```
The guts of this `wait` helper are pulled from the `wait` acceptance
test helper in Ember itself. Eventually we may be able to make Ember
itself provide an implementation that we can share here and in the
acceptance testing world.
rwjblue
force-pushed
the
add-wait-helper
branch
from
e021c48
to
e4eaebe
Compare
|
Added AJAX waiting support. |
|
Looks like an advanced testing tutorial/video might be nice, since there have been so many testing changes recently. |
9 tasks
|
I just want to point out that |
|
Long live |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows component integration tests that need to deal with async interactions to have an easy way to model their tests.
Example test (assuming the component does some async in an action triggered by the button click):
The guts of this
waithelper are pulled from thewaitacceptance test helper in Ember itself. Eventually we may be able to make Ember itself provide an implementation that we can share here and in the acceptance testing world.