Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add id and until to deprecations. #102

Merged
merged 1 commit into from
Sep 14, 2015
Merged

Add id and until to deprecations. #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions lib/ember-test-helpers/test-module-for-component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,14 @@ export default TestModule.extend({
} else if (callbacks.integration) {
this.isUnitTest = false;
} else {
Ember.deprecate("the component:" + componentName + " test module is implicitly running in unit test mode, which will change to integration test mode by default in an upcoming version of ember-test-helpers. Add `unit: true` or a `needs:[]` list to explicitly opt in to unit test mode.");
Ember.deprecate(
"the component:" + componentName + " test module is implicitly running in unit test mode, " +
"which will change to integration test mode by default in an upcoming version of " +
"ember-test-helpers. Add `unit: true` or a `needs:[]` list to explicitly opt in to unit " +
"test mode.",
false,
{ id: 'ember-test-helpers.test-module-for-component.test-type', until: '0.6.0' }
);
this.isUnitTest = true;
}

Expand Down Expand Up @@ -96,7 +103,11 @@ export default TestModule.extend({
};

this.callbacks.append = function() {
Ember.deprecate('this.append() is deprecated. Please use this.render() or this.$() instead.');
Ember.deprecate(
'this.append() is deprecated. Please use this.render() or this.$() instead.',
false,
{ id: 'ember-test-helpers.test-module-for-component.append', until: '0.6.0' }
);
return context.$();
};

Expand Down