Upgrade to ember 4.9 (in development) #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagenet
approved these changes
Nov 30, 2022
|
Oops, merging this closed emberjs/ember.js#20254 because I said "will help resolve" lolol |
bertdeblock
reviewed
Dec 1, 2022
| @@ -2,4 +2,5 @@ | |||
|
|
|||
| module.exports = { | |||
| singleQuote: true, | |||
| extends: 'recommended', | |||
There was a problem hiding this comment.
Is this a valid Prettier option? I haven't seen this before and I can't seem to find it in the docs.
There was a problem hiding this comment.
It is not. IDK how it got there TBH. The only extends: 'recommended' I can find in the blueprints is in a different file https://github.com/ember-cli/ember-cli/blob/1e415adb425fe219f4d8708be64c792be81f7385/blueprints/app/files/.template-lintrc.js#L3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to use the preview types when resolving #957, which will help resolve emberjs/ember.js#20254