Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helpful utilities for deprecations and warnings #868

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Add helpful utilities for deprecations and warnings #868

wants to merge 6 commits into from

Conversation

stefanpenner
Copy link
Member

@stefanpenner stefanpenner commented Jul 29, 2021 •
edited
Loading

This is one of the steps needed to deprecate https://github.com/workmanw/ember-qunit-assert-helpers (by rolling in the helpful assertions)

Depends on emberjs/ember-test-helpers#1071

@stefanpenner stefanpenner marked this pull request as draft July 29, 2021 22:54
@stefanpenner stefanpenner force-pushed the assertions branch 2 times, most recently from c0e2bc8 to 9286e89 Compare July 30, 2021 16:12
@stefanpenner stefanpenner force-pushed the assertions branch 2 times, most recently from cde065f to 10e4a37 Compare August 2, 2021 23:42
@stefanpenner stefanpenner changed the title Add deprecation assertions Add ember-qunit-assert-helpers assertions Aug 3, 2021
This was referenced Aug 3, 2021
Closed
Closed
Open
Open
@stefanpenner stefanpenner force-pushed the assertions branch 4 times, most recently from 0a136d3 to 53de824 Compare August 12, 2021 15:54
@stefanpenner
Copy link
Member Author

i don't have time to work on this

@buschtoens buschtoens mentioned this pull request Oct 17, 2021
Open
@chriskrycho
Copy link
Contributor

@stefanpenner thanks for clarifying the state on this as you hit your out-of-time spot. If someone wants to pick it up, could you potentially carve out 15–30 minutes to get them up to speed on the issues?

@rwjblue
Copy link
Member

rwjblue commented Oct 7, 2022

@chriskrycho - I'm probably the best contact person there (@stefanpenner handed off to me, but I ran into the same general "out of time" issue).

@rwjblue rwjblue force-pushed the assertions branch 3 times, most recently from 9afc11c to 77722bd Compare October 24, 2022 18:29
@rwjblue rwjblue changed the title Add ember-qunit-assert-helpers assertions Add helpful utilities for deprecations, warnings, and assertions Oct 24, 2022
@rwjblue rwjblue changed the title Add helpful utilities for deprecations, warnings, and assertions Add helpful utilities for deprecations and warnings Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanpenner @chriskrycho @rwjblue