Skip to content

[BUGFIX] Destroy components on teardown. #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2014

Conversation

gordonkristan
Copy link
Contributor

I was experiencing the issue in #64 and needed some way to properly tear down a component after a test was completed, otherwise lingering event observers hung around. This fix solved the issues that I was having. However, I wasn't quite sure how to test the fix, since the real work happens in the test teardown. So if anybody has an idea for how to test this, let me know and I'll add some tests.

@stravid
Copy link

stravid commented Sep 4, 2014

I just ran into this same issue. Do you plan to merge this pull request @rpflorence @rwjblue ?

If I can help with anything I will gladly do so :-) (Although I will need a lot of hand holding in the beginning, basically I only know how to write Ember.js applications. So I have no clue about any of the libraries and tools around it.)

rwjblue added a commit that referenced this pull request Sep 5, 2014
[BUGFIX] Destroy components on teardown.
@rwjblue rwjblue merged commit f1030c2 into emberjs:master Sep 5, 2014
@shredding
Copy link

I'm new to ember as well. Can you give me a hint on how to apply this fix to my project? I upgraded ember-cli, ember-cli-qunit, ember-qunit and added the code by hand, but i see no changes.

Even if i destroy the code with invalid syntax, it still compiles the testsuite fine, so i guess there is some kind of cache ...

Thanks in advance.

@gordonkristan
Copy link
Contributor Author

@shredding It's hard to say exactly what is going wrong without more details. Regardless, this isn't really the place for asking questions. If you've having trouble, StackOverflow is the best place to ask. Most of us check the Ember tag at least once a day.

@shredding
Copy link

kay, will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants