Update migration.md #815
Merged
Update migration.md #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
scalvert
previously approved these changes
Feb 9, 2021
|
In retrospect, after approving this PR, I realized it is a bit odd to have to add this in the migration guide, since this guide is explicitly for upgrading to v5.x.x. |
delete-merged-branch
bot
deleted the
hjdivad/migration-guide-qunit-dom-clarity
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rwjblue I've seen a couple of people run into issues where they treated the migration steps as preparatory work, not realizing that they can't make the
qunit-domchanges successfully with a4.x.xversion ofember-qunit.