Clarified migration guide to v5.x when a project includes QUnit DOM #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijlee2
commented
Dec 7, 2020
|
|
||
| ```sh | ||
| # npm users | ||
| npm install --save-dev qunit "@ember/test-helpers@^2.0.0-beta.4" | ||
| npm install --save-dev qunit "@ember/test-helpers" |
There was a problem hiding this comment.
The changes in this section are somewhat outside of PR scope (documenting what to do for QUnit DOM).
I didn't think it'd be good to show installing the beta version when stable is now available. I can revert this change, or address it differently if needed.
rwjblue
approved these changes
Dec 8, 2020
|
|
||
| ```sh | ||
| # npm users | ||
| npm install --save-dev qunit "@ember/test-helpers@^2.0.0-beta.4" | ||
| npm install --save-dev qunit "@ember/test-helpers" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I tried upgrading
ember-qunittov5.1in a production app today. I followed the migration guide by installingqunitand@ember/test-helpersand updatingtests/index.html.When I ran tests afterwards with
ember t -s, I encountered the error messageassert.dom is not a functionin all tests that relied on QUnit DOM assertions. From the migration guide, I didn't realize there were extra step(s) for QUnit DOM.I updated the migration guide by copy-pasting the code snippet from QUnit DOM's migration guide, then linking to the page in case there may be additional content in the future.