Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove polyfillMemoryLeakPrevention #336

Merged
merged 1 commit into from
Sep 27, 2018
+2 −22
Merged

Remove polyfillMemoryLeakPrevention #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions addon-test-support/ember-qunit/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,21 +243,6 @@ export function setupTestIsolationValidation() {
QUnit.done(reportIfTestNotIsolated);
}

// This polyfills the changes from https://github.com/qunitjs/qunit/pull/1279
// and should be removed when that change is released and included in a release
// version of QUnit
function polyfillMemoryLeakPrevention() {
QUnit.testDone(function() {
// release the test callback
QUnit.config.current.callback = undefined;
});

QUnit.moduleDone(function() {
// release the module hooks
QUnit.config.current.module.hooks = {};
});
}

/**
@method start
@param {Object} [options] Options to be used for enabling/disabling behaviors
Expand All @@ -275,7 +260,6 @@ function polyfillMemoryLeakPrevention() {
of `Ember.onerror` will be disabled.
@param {Boolean} [options.setupTestIsolationValidation] If `false` test isolation validation
will be disabled.
@param {Boolean} [options._polyfillMemoryLeakPrevention] If `false` the polyfilled memory leak prevention will not be enabled.
*/
export function start(options = {}) {
if (options.loadTests !== false) {
Expand Down Expand Up @@ -305,10 +289,6 @@ export function start(options = {}) {
setupTestIsolationValidation();
}

if (options._polyfillMemoryLeakPrevention !== false) {
polyfillMemoryLeakPrevention();
}

if (options.startTests !== false) {
startTests();
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"common-tags": "^1.4.0",
"ember-cli-babel": "^6.8.2",
"ember-cli-test-loader": "^2.2.0",
"qunit": "^2.5.0"
"qunit": "^2.6.0"
},
"devDependencies": {
"ember-cli": "~2.15.1",
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6166,7 +6166,7 @@ quick-temp@^0.1.2, quick-temp@^0.1.3, quick-temp@^0.1.5, quick-temp@^0.1.8:
rimraf "^2.5.4"
underscore.string "~3.3.4"

qunit@^2.5.0:
qunit@^2.6.0:
version "2.6.2"
resolved "https://registry.yarnpkg.com/qunit/-/qunit-2.6.2.tgz#551210c5cf857258a4fe39a7fe15d9e14dfef22c"
integrity sha512-PHbKulmd4rrDhFto7iHicIstDTX7oMRvAcI7loHstvU8J7AOGwzcchONmy+EG4KU8HDk0K90o7vO0GhlYyKlOg==
Expand Down