Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix leak #274

Merged
merged 1 commit into from
Jun 7, 2017
Merged

fix leak #274

merged 1 commit into from
Jun 7, 2017

Conversation

stefanpenner
Copy link
Member

No description provided.

@stefanpenner stefanpenner force-pushed the fix-leak branch 2 times, most recently from 32230ee to 8369832 Compare June 7, 2017 00:06
trentmwillis
trentmwillis approved these changes Jun 7, 2017
View reviewed changes
Copy link
Member

@trentmwillis trentmwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice use of finally.

@stefanpenner stefanpenner merged commit 8278a2e into master Jun 7, 2017
@stefanpenner stefanpenner deleted the fix-leak branch June 7, 2017 03:27
@stefanpenner
Copy link
Member Author

@trentmwillis / @rwjblue I can't release, mind adding me as an npm owner?

@trentmwillis
Copy link
Member

Done!

@stefanpenner
Copy link
Member Author

stefanpenner commented Jun 7, 2017 •
edited
Loading

@trentmwillis looks like there is a lag before npm lets me... Mind releasing before i forget?

@stefanpenner
Copy link
Member Author

@trentmwillis nvm, released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentmwillis trentmwillis trentmwillis approved these changes

@rwjblue rwjblue Awaiting requested review from rwjblue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanpenner @trentmwillis