Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ember 5 compatibility #1026

Closed
Tracked by #54
, #38
...
simonihmig opened this issue Feb 21, 2023 · 3 comments · Fixed by #1027
Closed
Tracked by #54
, #38
...

Ember 5 compatibility #1026

simonihmig opened this issue Feb 21, 2023 · 3 comments · Fixed by #1027

Comments

@simonihmig
Copy link
Contributor

With canary now pointing to 5.0.0-alpha, we are seeing CI failures here as well as in other addons.

The first trivial fix is to include 5.x in our peer dependencies. Idk if there is more to that though...
@simonihmig simonihmig mentioned this issue Feb 21, 2023
Closed
1 task
simonihmig added a commit to CrowdStrike/ember-headless-form that referenced this issue Feb 21, 2023
@simonihmig
Skip canary tests for now
b4404e8 
ember-qunit has peerDependency problems failing the build (emberjs/ember-qunit#1026). Other upstream dependencies maybe also. For now skipping canary from the CI matrix to unblock CI. Need to re-enable this, tracking issue: #54
simonihmig added a commit to CrowdStrike/ember-headless-form that referenced this issue Feb 21, 2023
@simonihmig
Skip canary tests for now
8d49c6b 
ember-qunit has peerDependency problems failing the build (emberjs/ember-qunit#1026). Other upstream dependencies maybe also. For now skipping canary from the CI matrix to unblock CI. Need to re-enable this, tracking issue: #54
@simonihmig simonihmig mentioned this issue Feb 21, 2023
Merged
@ynotdraw ynotdraw mentioned this issue Feb 21, 2023
Closed
1 task
@NullVoxPopuli
Copy link
Sponsor Collaborator

NullVoxPopuli commented Feb 23, 2023 •
edited
Loading

Just ran in to this on NullVoxPopuli/buttered-ember#11 🎉
Apparently the other project I've worked on today ignored this error 🙈 https://github.com/NullVoxPopuli/ember-resources/actions/runs/4253375151/jobs/7398228102#step:5:56

This was referenced Feb 24, 2023
Merged
Merged
@jelhan jelhan mentioned this issue Feb 24, 2023
Merged
@jelhan
Copy link
Contributor

jelhan commented Feb 25, 2023

Maybe we should keep this issue open until release. I fear many will run into it as default CI pipelines fail for addons currently.

@chriskrycho
Copy link
Contributor

Released as v6.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support Ember v5 jelhan/ember-qunit
4 participants
@NullVoxPopuli @simonihmig @chriskrycho @jelhan