Skip to content

Enable command is destructive in an addon #74

@patocallaghan

Description

@patocallaghan
ember-cli: 3.7.1
node: 10.15.0
os: darwin x64
optional-features addon: 0.7.0
  1. Install addon ember install @ember/optional-features
  2. Enable jquery-integration ember feature:enable jquery-integration
➜  test-addon git:(master) ✗ node_modules/.bin/ember feature:enable jquery-integration
Enabled jquery-integration. Be sure to commit config/optional-features.json to source control!
➜  test-addon git:(master) ✗ cat tests/dummy/config/optional-features.json
{
  "jquery-integration": true
}
  1. Enable another feature e.g. template-only-glimmer-components
➜  test-addon git:(master) ✗ node_modules/.bin/ember feature:enable template-only-glimmer-components
Enabled template-only-glimmer-components. Be sure to commit config/optional-features.json to source control!
➜  test-addon git:(master) ✗ cat tests/dummy/config/optional-features.json
{
  "template-only-glimmer-components": true
}
  1. It should add your newly enabled feature to the list but instead it is destructive. The enable command is destructive and overwrites any previously added features in the addon's dummy app config.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions