Use [class='ember-view'] selector to exclude anything with extra classes #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should exclude liquid-fire elements or various others that add classes to the application container ember-view. If you were adding your own classes to the application container, this would break, but I think this supports the majority of cases, and application wrappers are disabled by a lot of people these days anyway. Resolves #419
RobbieTheWagner
requested review from
nummi,
thorsteinsson,
Bestra and
pbishop16
rwjblue
reviewed
Oct 9, 2018
rwjblue
approved these changes
Oct 9, 2018
cyril-sf
pushed a commit
to cyril-sf/ember-inspector
that referenced
this pull request
Mar 30, 2022
…ses (emberjs#874) This should exclude liquid-fire elements or various others that add classes to the application container ember-view. If you were adding your own classes to the application container, this would break, but I think this supports the majority of cases, and application wrappers are disabled by a lot of people these days anyway. Resolves emberjs#419
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should exclude liquid-fire elements or various others that add classes to the application container ember-view.
If you were adding your own classes to the application container, this would break, but I think this supports the majority of cases, and application wrappers are disabled by a lot of people these days anyway.
Resolves #419
@emberjs/inspector what do you guys think of this? It would hide liquid-fire etc from the view tree, but I think that is okay?