add request permissions page #2569
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricklx
force-pushed
the
request-permissions
branch
7 times, most recently
from
62ea45c
to
0f02cd1
Compare
patricklx
force-pushed
the
request-permissions
branch
from
0f02cd1
to
9f96de0
Compare
|
@patricklx can you please explain in more detail what this PR is for? Is it just a shortcut to request permissions? Can we not add the request permissions stuff to the icon in the toolbar of Chrome? |
|
@RobbieTheWagner in the toolbar you can already click on the ember icon and select which permissions to give to local website. So this is just a shortcut and a link to the page will be presented on the ember inspector error page. |
patricklx
requested review from
RobbieTheWagner
and removed request for
RobbieTheWagner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2516
Description
this adds a link to a request permission page for ember inspector.
It can only be requested during an user action, like a click.
The page will open in a separate window, this is one of the possibilities to request permissions.
It cannot be done directly from the extension page in devtools.
Screenshots