-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add highlight render option to Render Performance tab #1685
Conversation
5ce959a
to
549c486
Compare
192555d
to
1cd3dc7
Compare
It's beautiful! |
135793e
to
e351e46
Compare
e351e46
to
5a360b3
Compare
76ac347
to
cfcb28f
Compare
cfcb28f
to
5b18abc
Compare
42def62
to
78d47ef
Compare
c5a2bd8
to
e90228b
Compare
@rwwagner90 please review :) |
@MelSumner we're not merging new things until the build is fixed and working with beta and canary, but we will definitely review all open PRs when that time comes. |
@michaelbdai now that master has passing tests, can you please rebase? |
@rwwagner90 rebased. all tests passing now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this super in depth PR @michaelbdai! I especially appreciate that you added so many great tests! I just had a few minor questions, but otherwise, this looks good to me.
Thanks again so much for the PR! 🎉 |
* add highlight render option to Render Performance tab clean up * fix lint error and change per comment * Use bounds to find component instead of id * change per comment * change per comments * change per comments * change per comments * added test * replace timeout with later * use async * improve tests * add test for glimmer component, to show the highlight is not supported. * change per comments Co-authored-by: Bing Dai <[email protected]>
Description
for issue #1684
Added a checkbox in the render performance tab/route
When enabled, the component gets highlighted when rends.
See more details in screen recording.
Screenshots
Here is the screen recording and unpacked build
https://drive.google.com/file/d/1jIUPaM69okID1tlroAFu8lead6zeKfi_/view?usp=sharing