Chrome freezes tab with Ember Inspector extension #690

ghost · 2017-07-21T09:21:30Z

Hello,

I'm using latest Chrome and Ember Inspector extension. The problem is, when you enable Ember Inspector extension and you go to the Data and use unloadRecord() for e.g. I have Delete button which unloads record after delete and when I press it Chrome tab will freeze and uses a lot of memory and CPU. When I turn off ember extension everything works fine with developer tools opened, but with ember inspector extension I get this. Nothing helped, I even cleaned cache, settings and so on.

If you don't open Developer Tools with Ember - everything is OK.
If you open Developer Tools for e.g. with Console tab - everything is OK.
If you open Developer Tools with Ember - everything is OK.
If you open Developer Tools with Ember and you go the Data - chrome tab freezes and uses a lot of resources.

The text was updated successfully, but these errors were encountered:

ghost · 2017-07-21T09:47:51Z

Seems it also freezes if extension is just enabled, but you're not in Data with Ember Inspector. But to reproduce it 100% you need go to the Data.

ewjoachim · 2017-07-30T14:02:12Z

I have no idea if it's linked, but I have another case of Chrome + Firefox freezing + using 100% of CPU when selecting a specific model on the Data panel... Details and a minimum reproduction setup are here (well, as minimum as I could make that). See the readme for all the details.

ewjoachim · 2017-07-30T16:31:11Z

For what it's worth, it seems other people have been posting messages on Slack related to problems that look similar :

https://embercommunity.slack.com/archives/C04ENQPFW/p1501207850719655

nlincoln wrote:
I just upgraded ember-data from 2.14.4 to 2.14.7 today and now when I try to view models inside of the data part of the inspector chrome just starts eating memory, the page becomes completely unresponsive and I have to kill both the page and the chrome devtools via the chrome task manager to get things to work again

ewjoachim · 2017-07-30T22:20:00Z

For me the problem is not visible with ember-data 2.13.2 and is there with 2.14.x, whatever the x (up until 7).

stephanebruckert · 2017-08-04T15:33:20Z

Same here, happens only when the data tab of the ember inspector is open. In my case it's caused by destroyRecord() which probably clears the data the same way as unloadRecord() (used by OP) does.

self.get('store').find('token', tokenId).then(function(a) {
    a.destroyRecord()
})

100% of the CPU is used, the memory keeps increasing and nothing is showed in the console

✗ ember -v
ember-cli: 2.13.1
node: 7.9.0
os: darwin x64

Ember Inspector 2.0.6
Chrome Version 60.0.3112.90 (Official Build) (64-bit)

Initially thought something was wrong in my code and took me a long time to figure it wasn't the case, as I always keep the data tab open! 😅

ghost · 2017-08-04T18:09:42Z

@stephanebruckert Everything is same for me. Even the last sentence 😄 It's just impossible to work with Ember Inspector, but I really need it to see the routes, data and so on.

kernel-io · 2017-08-07T13:14:12Z

Also happening to me, luckily it did not take me long to figure out it wasn't my fault considering it is a new project 😄

stephanebruckert · 2017-08-07T13:26:04Z

I wrote my destroyRecord a bit differently and the issue is not happening anymore:

// hack https://github.com/emberjs/data/issues/4972#issuecomment-312301105
this.get('store')._removeFromIdMap(this.get('model.calendarToken')._internalModel);
this.get('model.calendarToken').destroyRecord();

according to emberjs/data#4972 (comment)

IAmJulianAcosta · 2017-08-10T14:23:37Z

Check that your data is loading fine, had an issue with it in the last month, and it was caused by malformed/corrupt data, that freezes data tab. I had to comment the queries until I found the model that was causing the problem. YMMV

ewjoachim · 2017-08-10T14:40:51Z

No kind of malformed data should silently bug and crash your tab, without even a single error message...

IAmJulianAcosta · 2017-08-10T20:34:49Z

I agree, but that probably will unlock other people with the same problem while is fixed :)

sammynave · 2017-08-11T03:51:41Z

If this helps anyone, here's a project and steps to repro the issue: https://github.com/sammynave/freeze

urbany · 2017-08-11T14:50:14Z

Got hit by this today, on [email protected] seems to happen when I delete an unsaved record

tomgazit · 2017-08-14T08:21:07Z

experiencing the same issue....

elke1979 · 2017-08-14T08:27:01Z

I use Chrome (Version 60.0.3112.90 (Official Build) (64-bit)) + the latest Ember Inspector extension.
If I log into https://www.emberjs.com/api/ember/2.14/namespaces/Ember (Ember API website) and I browse the Ember Inspector the browser freezes when I click "Data".

pomm0 · 2017-08-22T09:40:55Z

have the same problem, any news? :(
It freezes firefox too

teddyzeenny · 2017-08-26T12:44:14Z

Thank you all for the detailed bug report. I was able to reproduce it and I'm investigating the issue.

… count actually changed Fixes emberjs/ember-inspector#690 The issue: In some cases, Ember Data's `peekAll` triggers `arrayContentDidChange` on the record array manager's live record array even if the records didn't change. One example case is when we call `unloadRecord` and then `peekAll` within the same run loop. The `peekAll` will trigger the array observer's `didChange` callback (with zero changes). This is generally harmless as long as we guard against that in our data adapter. Without the guard, we risk causing an infinite recursion because our `didChange` observer itself calls `peekAll`, which in the above scenario will re-trigger the observer and so on.

teddyzeenny · 2017-08-27T13:45:53Z

I identified the issue and proposed a solution emberjs/ember.js#15604.
The downside is that this is not a bug in the inspector itself, which means you'll need to upgrade your Ember version to get the fix.

… count actually changed Fixes emberjs/ember-inspector#690 The issue: In some cases, Ember Data's `peekAll` triggers `arrayContentDidChange` on the record array manager's live record array even if the records didn't change. One example case is when we call `unloadRecord` and then `peekAll` within the same run loop. The `peekAll` will trigger the array observer's `didChange` callback (with zero changes). This is generally harmless as long as we guard against that in our data adapter. Without the guard, we risk causing an infinite recursion because our `didChange` observer itself calls `peekAll`, which in the above scenario will re-trigger the observer and so on. (cherry picked from commit 7bd47da)

teddyzeenny self-assigned this Aug 26, 2017

teddyzeenny mentioned this issue Aug 27, 2017

Data Adapter: Only trigger model type update if the record live array count actually changed emberjs/ember.js#15604

Merged

workmanw mentioned this issue Sep 14, 2017

Ember Model Fragments Freezes Chrome DevTools/Ember Inspector adopted-ember-addons/ember-data-model-fragments#278

Open

rwjblue closed this as completed in emberjs/ember.js#15604 Oct 4, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chrome freezes tab with Ember Inspector extension #690

Chrome freezes tab with Ember Inspector extension #690

ghost commented Jul 21, 2017

ghost commented Jul 21, 2017

ewjoachim commented Jul 30, 2017 •

edited

Loading

ewjoachim commented Jul 30, 2017

ewjoachim commented Jul 30, 2017

stephanebruckert commented Aug 4, 2017 •

edited

Loading

ghost commented Aug 4, 2017 •

edited by ghost

Loading

kernel-io commented Aug 7, 2017

stephanebruckert commented Aug 7, 2017 •

edited

Loading

IAmJulianAcosta commented Aug 10, 2017

ewjoachim commented Aug 10, 2017

IAmJulianAcosta commented Aug 10, 2017

sammynave commented Aug 11, 2017

urbany commented Aug 11, 2017

tomgazit commented Aug 14, 2017

elke1979 commented Aug 14, 2017

pomm0 commented Aug 22, 2017 •

edited

Loading

teddyzeenny commented Aug 26, 2017

teddyzeenny commented Aug 27, 2017

Chrome freezes tab with Ember Inspector extension #690

Chrome freezes tab with Ember Inspector extension #690

Comments

ghost commented Jul 21, 2017

ghost commented Jul 21, 2017

ewjoachim commented Jul 30, 2017 • edited Loading

ewjoachim commented Jul 30, 2017

ewjoachim commented Jul 30, 2017

stephanebruckert commented Aug 4, 2017 • edited Loading

ghost commented Aug 4, 2017 • edited by ghost Loading

kernel-io commented Aug 7, 2017

stephanebruckert commented Aug 7, 2017 • edited Loading

IAmJulianAcosta commented Aug 10, 2017

ewjoachim commented Aug 10, 2017

IAmJulianAcosta commented Aug 10, 2017

sammynave commented Aug 11, 2017

urbany commented Aug 11, 2017

tomgazit commented Aug 14, 2017

elke1979 commented Aug 14, 2017

pomm0 commented Aug 22, 2017 • edited Loading

teddyzeenny commented Aug 26, 2017

teddyzeenny commented Aug 27, 2017

ewjoachim commented Jul 30, 2017 •

edited

Loading

stephanebruckert commented Aug 4, 2017 •

edited

Loading

ghost commented Aug 4, 2017 •

edited by ghost

Loading

stephanebruckert commented Aug 7, 2017 •

edited

Loading

pomm0 commented Aug 22, 2017 •

edited

Loading