-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to guess at better pathings? #2425
Comments
what could be the best way here? though embroider should already take care of the leading path to app dir: or should this be fixed in embroider to ouput the same as classic builds? so, the goal is to have moduleName be the real path? however i would argue that that is not a moduleName then. or at least not a useful one with all the linking in between... also, I also do not see a way to remove the leading path to the root dir... I think this should really be fixed in embroider and ember-template-imports |
rootDir is not always enough/correct. it ends with /rewritten-app. but there is also /rewritten-packages which will keep the full path. same for node_modules, which have the full path see emberjs/ember-inspector#2425
rootDir is not always enough/correct. it ends with /rewritten-app. but there is also /rewritten-packages which will keep the full path. same for node_modules, which have the full path see emberjs/ember-inspector#2425
The key question here is: why do we think templates need this special form of debugging info to point back at their source, when we don't expect the same from every javascript module? That distinction used to make sense, because templates used to be entirely separate from javascript. But now they are just values inside javascript. moduleName isn't even enough to uniquely locate a template anymore, given that you can have dozens of template tags in one module. The inspector feature here should be more like a "jump to source" button. If instead of embedding t.createTemplateFactory)({
id: "efyYydg8",
block: '[[[8,[39,0],null,null,null]],[],false,["four-oh-four"]]',
- moduleName: "pdpm-calc/templates/404.hbs",
+ debugHandle: function() {},
isStrictMode: !1
}) then at runtime the inspector can do (I think it has to be a function because |
@ef4 I would be open to that. |
@ef4 good idea, but then moduleName should not be set if nothing is passed to the template compiler. Currently the template compiler sets it to a filename |
I'm creating an RFC issue to centralize discussion of this problem: emberjs/rfcs#940 |
Wee may still need |
Is your feature request related to a problem? Please describe.
Was just poking around and noticed this:
that path for the component is just hilarious -- almost goes across my whole screen lololol
Describe the solution you'd like
Maybe an option in the inspector settings to provide the module path, rather than path on disk?
Describe alternatives you've considered
keep it silly
The text was updated successfully, but these errors were encountered: