Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add missing @ember/string dependency to peers #501

Closed
wants to merge 8 commits into from
+73 −31
Closed

chore: add missing @ember/string dependency to peers #501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9796fb7
chore: add missing ember/string dependency
Techn1x Jul 10, 2024
07e6bcd
Update ember-try.js
Techn1x Jul 11, 2024
e3086e3
Merge pull request #2 from Techn1x/patch-1
Techn1x Jul 11, 2024
d28e896
Update tests/dummy/config/ember-try.js
Techn1x Jul 11, 2024
0b982a2
Update ember-try.js
Techn1x Jul 11, 2024
1cabca0
Merge pull request #3 from Techn1x/patch-2
Techn1x Jul 11, 2024
77266de
Update ci.yml
Techn1x Jul 11, 2024
0aa93d9
Merge pull request #4 from Techn1x/patch-3
Techn1x Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,9 @@ jobs:
- ember-lts-3.28
- ember-lts-4.4
- ember-lts-4.8
- ember-lts-4.12
- ember-lts-5.4
- ember-lts-5.8
- ember-release
- ember-beta
- ember-canary
Expand Down
71 changes: 41 additions & 30 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"@babel/eslint-parser": "^7.21.3",
"@babel/plugin-proposal-decorators": "^7.21.0",
"@ember/optional-features": "^2.0.0",
"@ember/string": "^3.0.1",
"@ember/string": "^4.0.0",
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ember/string @ v4 can't support ember-source < 3.28

So... it might be impossible to use @ember/string @ v4 until we do a modern version of ember-inflector (which @mansona already has a PR for)

Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder though if it would work if we set this to @ember/string: ^3.0.0 || ^4.0.0 and configured the exact version in the try config.

also, I feel like someane already said that, and I'm too scattered today :(

"@ember/test-helpers": "^2.9.3",
"@embroider/test-setup": "^3.0.0",
"@glimmer/component": "^1.1.2",
Expand Down Expand Up @@ -76,6 +76,7 @@
"webpack": "^5.78.0"
},
"peerDependencies": {
"@ember/string": "^3.1.1 || ^4.0.0",
"ember-source": "^3.16.0 || ^4.0.0 || ^5.0.0"
},
"engines": {
Expand Down
27 changes: 27 additions & 0 deletions tests/dummy/config/ember-try.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ module.exports = async function () {
name: 'ember-lts-3.16',
npm: {
devDependencies: {
'@ember/string': '^3.1.1',
'ember-source': '~3.16.0',
'ember-qunit': '^5.0.0',
},
Expand All @@ -19,6 +20,7 @@ module.exports = async function () {
name: 'ember-lts-3.20',
npm: {
devDependencies: {
'@ember/string': '^3.1.1',
'ember-source': '~3.20.0',
'ember-qunit': '^5.0.0',
},
Expand All @@ -28,6 +30,7 @@ module.exports = async function () {
name: 'ember-lts-3.24',
npm: {
devDependencies: {
'@ember/string': '^3.1.1',
'ember-source': '~3.24.3',
'ember-qunit': '^5.0.0',
},
Expand Down Expand Up @@ -57,6 +60,30 @@ module.exports = async function () {
},
},
},
{
name: 'ember-lts-4.12',
npm: {
devDependencies: {
'ember-source': '~4.12.0',
},
},
},
{
name: 'ember-lts-5.4',
npm: {
devDependencies: {
'ember-source': '~5.4.0',
},
},
},
{
name: 'ember-lts-5.8',
npm: {
devDependencies: {
'ember-source': '~5.8.0',
},
},
},
{
name: 'ember-release',
npm: {
Expand Down
Loading