Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide addon's own public build time API for enabling/disabling deprecations #60

Closed
rwjblue opened this issue Feb 12, 2018 · 1 comment
Assignees

Comments

@rwjblue
Copy link
Member

rwjblue commented Feb 12, 2018

The internal usage of underscored EmberENV properties for toggling deprecated features should not be made to seem as public API (we currently mention in our README).

Instead, we should provide our own build time API to allow toggling. Something like:

new EmberApp(defaults, {
  'ember-2-legacy': {
    'underscore-actions-support': false
  }
})

The default for each item would be true, and you'd override with false to disable a given legacy feature.

@thoov
Copy link
Member

thoov commented Feb 12, 2018

Working on this now

thoov added a commit to thoov/ember-2-legacy that referenced this issue Feb 13, 2018
thoov added a commit to thoov/ember-2-legacy that referenced this issue Feb 14, 2018
thoov added a commit to thoov/ember-2-legacy that referenced this issue Mar 8, 2018
@thoov thoov closed this as completed in 8fabc06 Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants