Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: use store for save-record docs #9299

Merged
merged 1 commit into from
Mar 29, 2024
Merged

doc: use store for save-record docs #9299

merged 1 commit into from
Mar 29, 2024

Conversation

Yelinz
Copy link
Contributor

@Yelinz Yelinz commented Mar 27, 2024

Description

Sometimes was this.store other times store, changed to this.store consistently

@Yelinz
Copy link
Contributor Author

Yelinz commented Mar 27, 2024

saw a few more inconsistencies in json-api and in the other files in rest.
Now I'm not sure what the intent is. If it should be only store or this.store

removes this.store because the doc example is not inside a class for
rest, json-api and active-record
@Yelinz Yelinz changed the title doc(rest): consistently use this.store in save-record doc: use store for save-record docs Mar 28, 2024
@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ doc This PR adds/improves/or fixes documentation labels Mar 29, 2024
@runspired runspired merged commit 72b1e21 into emberjs:main Mar 29, 2024
29 of 33 checks passed
@Yelinz Yelinz deleted the rest-save-store branch March 30, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 canary PR is targeting canary (default) 🏷️ doc This PR adds/improves/or fixes documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants