Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: url configuration should respect / for host and error more meaningfully when invalid #9164

Merged
merged 2 commits into from
Dec 10, 2023

Conversation

runspired
Copy link
Contributor

resolves #9107
resolves #9118

@runspired runspired added 🎯 release PR should be backported to release 🎯 canary PR is targeting canary (default) 🎯 lts The PR should be backported to the most recent LTS 🏷️ bug This PR primarily fixes a reported issue lts-4-12 Long Term LTS Maintenance labels Dec 10, 2023
@runspired runspired merged commit d0b7878 into main Dec 10, 2023
19 of 20 checks passed
@runspired runspired deleted the cleanup-request-utils branch December 10, 2023 08:02
Baltazore pushed a commit to Baltazore/data that referenced this pull request Dec 21, 2023
…ngfully when invalid (emberjs#9164)

* fix: url configuration should respect / for host and error more meaningfully when invalid

* fix prettier
runspired added a commit that referenced this pull request Feb 13, 2024
…ngfully when invalid (#9164)

* fix: url configuration should respect / for host and error more meaningfully when invalid

* fix prettier
runspired added a commit that referenced this pull request Feb 13, 2024
* fix: JSONAPISerializer should not reify empty records (#8934)

* fix: JSONAPISerializer should not reify empty records

* fix lint

* fix: url configuration should respect / for host and error more meaningfully when invalid (#9164)

* fix: url configuration should respect / for host and error more meaningfully when invalid

* fix prettier

* fix: keep a backreference for previously merged identifiers (#9183)

* fix: keep a backreference for previously merged identifiers

* update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 canary PR is targeting canary (default) 🎯 lts The PR should be backported to the most recent LTS 🎯 release PR should be backported to release 🏷️ bug This PR primarily fixes a reported issue lts-4-12 Long Term LTS Maintenance
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

BUG: Cannot set host relative to site root unhelpful error when using setBuildURLConfig
1 participant