Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support full range of json:api for references, update docs #9159

Merged
merged 4 commits into from
Dec 10, 2023

Conversation

runspired
Copy link
Contributor

This PR improves belongsTo and hasMany references by

  • overhauling their documentation
  • improving the associated documentation on Model for retrieving a relationship reference
  • fixing some bugs in their push signatures that occurred due to a past incompletely cleaned up deprecation
  • improves their push capabilities to accept any valid JSON:API document, this allows managing the relationship's links & meta via push possible.
  • improves their push capabilities to allow manipulating the state without forcing the fetch of any unloaded data
  • improves their push capabilities to better support pushing resource-identifiers without associated resource data.

Thanks to this discord thread for pointing out there was a problem here https://discord.com/channels/480462759797063690/486549196837486592/1182801175767154718

@runspired runspired added 🏷️ feat This PR introduces a new feature 🏷️ doc This PR adds/improves/or fixes documentation 🏷️ bug This PR primarily fixes a reported issue labels Dec 10, 2023
@runspired runspired self-assigned this Dec 10, 2023
@runspired runspired added the 🎯 canary PR is targeting canary (default) label Dec 10, 2023
@runspired runspired merged commit 546b5fd into main Dec 10, 2023
19 of 20 checks passed
@runspired runspired deleted the fix-references branch December 10, 2023 01:30
Baltazore pushed a commit to Baltazore/data that referenced this pull request Dec 21, 2023
…rjs#9159)

* fix: support full range of json:api for references, update docs

* improve reference docs some more

* fix lint

* fix lint?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 canary PR is targeting canary (default) 🏷️ bug This PR primarily fixes a reported issue 🏷️ doc This PR adds/improves/or fixes documentation 🏷️ feat This PR introduces a new feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant