fix: unloadAll(void) should not destroy the notification manager #8684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
added a commit
that referenced
this pull request
Jul 6, 2023
* fix: unloadAll(void) should not destroy the notification manager * fix lint
runspired
added a commit
that referenced
this pull request
Jul 6, 2023
* fix: unloadAll(void) should not destroy the notification manager * fix lint
runspired
added a commit
that referenced
this pull request
Jul 7, 2023
…) (#8685) * fix: unloadAll(void) should not destroy the notification manager * fix lint
runspired
added a commit
that referenced
this pull request
Jul 7, 2023
…) (#8686) * fix: unloadAll(void) should not destroy the notification manager * fix lint
3 tasks
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses an issue reported in discord where in 4.12+ unloadAll(void) led to silently no data appearing to be in the store. This was due to improper teardown timing of the notification manager which this PR fixes.
https://discord.com/channels/480462759797063690/486549196837486592/1126451975467323422