[Cleanup]: Remove RECORD_ARRAY_MANAGER_IDENTIFIERS #7394

snewcomer · 2020-12-03T02:22:01Z

This flag helped us move from using Internal Models to Identifiers. With the 3.23 release, we can remove this flag.

github-actions · 2020-12-03T02:24:16Z

Performance Report for eb2a192

Relationship Analysis

                        -------------

__/\\\\\\\\\\\\\____/\\\\____________/\\\\____/\\\\\\\\\_____
 _\/\\\/////////\\\_\/\\\\\\________/\\\\\\__/\\\///////\\\___
  _\/\\\_______\/\\\_\/\\\//\\\____/\\\//\\\_\///______\//\\\__
   _\/\\\\\\\\\\\\\/__\/\\\\///\\\/\\\/_\/\\\___________/\\\/___
    _\/\\\/////////____\/\\\__\///\\\/___\/\\\________/\\\//_____
     _\/\\\_____________\/\\\____\///_____\/\\\_____/\\\//________
      _\/\\\_____________\/\\\_____________\/\\\___/\\\/___________
       _\/\\\_____________\/\\\_____________\/\\\__/\\\\\\\\\\\\\\\_
        _\///______________\///______________\///__\///////////////__


                          Runtime Edition

        PM2 is a Production Process Manager for Node.js applications
                     with a built-in Load Balancer.

                Start and Daemonize any application:
                $ pm2 start app.js

                Load Balance 4 instances of api.js:
                $ pm2 start api.js -i 4

                Monitor in production:
                $ pm2 monitor

                Make pm2 auto-boot at server restart:
                $ pm2 startup

                To go further checkout:
                http://pm2.io/


                        -------------

[PM2] Spawning PM2 daemon with pm2_home=/home/runner/.pm2
[PM2] PM2 Successfully daemonized
[PM2] Starting /home/runner/work/data/data/bin/relationship-performance-tracking/src/har-remix.js in fork_mode (1 instance)
[PM2] Done.
┌─────┬────────────┬─────────────┬─────────┬─────────┬──────────┬────────┬──────┬───────────┬──────────┬──────────┬──────────┬──────────┐
│ id  │ name       │ namespace   │ version │ mode    │ pid      │ uptime │ ↺    │ status    │ cpu      │ mem      │ user     │ watching │
├─────┼────────────┼─────────────┼─────────┼─────────┼──────────┼────────┼──────┼───────────┼──────────┼──────────┼──────────┼──────────┤
│ 0   │ control    │ default     │ N/A     │ fork    │ 2840     │ 0s     │ 0    │ online    │ 0%       │ 28.4mb   │ runner   │ disabled │
└─────┴────────────┴─────────────┴─────────┴─────────┴──────────┴────────┴──────┴───────────┴──────────┴──────────┴──────────┴──────────┘
[PM2] Starting /home/runner/work/data/data/bin/relationship-performance-tracking/src/har-remix.js in fork_mode (1 instance)
[PM2] Done.
┌─────┬───────────────┬─────────────┬─────────┬─────────┬──────────┬────────┬──────┬───────────┬──────────┬──────────┬──────────┬──────────┐
│ id  │ name          │ namespace   │ version │ mode    │ pid      │ uptime │ ↺    │ status    │ cpu      │ mem      │ user     │ watching │
├─────┼───────────────┼─────────────┼─────────┼─────────┼──────────┼────────┼──────┼───────────┼──────────┼──────────┼──────────┼──────────┤
│ 0   │ control       │ default     │ N/A     │ fork    │ 2840     │ 0s     │ 0    │ online    │ 0%       │ 66.8mb   │ runner   │ disabled │
│ 1   │ experiment    │ default     │ N/A     │ fork    │ 2878     │ 0s     │ 0    │ online    │ 0%       │ 22.9mb   │ runner   │ disabled │
└─────┴───────────────┴─────────────┴─────────┴─────────┴──────────┴────────┴──────┴───────────┴──────────┴──────────┴──────────┴──────────┘

===============================================================================
Processing CHANGELOG.md CODE_OF_CONDUCT.md CONTRIBUTING.md README.md RELEASE.md bin lerna.json node_modules package.json packages tmp tsconfig.json yarn.lock
[PM2] [v] Modules Stopped
[PM2] Applying action deleteProcessId on app [all](ids: [ 0, 1 ])
[PM2] [control](0) ✓
[PM2] [experiment](1) ✓
[PM2] [v] All Applications Stopped
[PM2] [v] PM2 Daemon Stopped

github-actions · 2020-12-03T02:26:52Z

Asset Size Report for eb2a192

IE11 Builds

EmberData shrank by 71.0 B (-22.0 B compressed)

If any packages had changed sizes they would be listed here.

Changeset


EmberData 161.64 KB -71.0 B (34.79 KB +22.0 B compressed)
    @ember-data/store 70.05 KB -71.0 B (15.08 KB +22.0 B compressed)
        @ember-data/store/-private 69.14 KB -71.0 B (14.88 KB +22.0 B compressed)

Full Asset Analysis (IE11)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '161.64 KB' │
│ compressed │ '34.79 KB'  │
│  packages  │      9      │
│  modules   │     46      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '70.05 KB' │
│  compressed  │ '15.08 KB' │
│ % Of Library │   '43.3'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 69.14 KB  | 14.88 KB   | 98.7          | 42.8
	@ember-data/store/index                           | 936.00 B  | 201.44 B   | 1.3           | 0.6

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.65 KB' │
│  compressed  │ '4.87 KB'  │
│ % Of Library │   '14.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 22.65 KB  | 4.87 KB    | 100.0         | 14.0

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.37 KB' │
│  compressed  │ '4.17 KB'  │
│ % Of Library │   '12.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.12 KB   | 1.53 KB    | 36.8          | 4.4
	@ember-data/serializer/-private                   | 5.37 KB   | 1.16 KB    | 27.7          | 3.3
	@ember-data/serializer/json-api                   | 3.72 KB   | 819.12 B   | 19.2          | 2.3
	@ember-data/serializer/rest                       | 2.71 KB   | 597.88 B   | 14.0          | 1.7
	@ember-data/serializer/index                      | 243.00 B  | 52.29 B    | 1.2           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 46.27 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.02 KB' │
│  compressed  │ '3.23 KB'  │
│ % Of Library │   '9.3'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 8.03 KB   | 1.73 KB    | 53.5          | 5.0
	@ember-data/adapter/-private                      | 3.58 KB   | 787.92 B   | 23.8          | 2.2
	@ember-data/adapter/error                         | 1.91 KB   | 421.61 B   | 12.7          | 1.2
	@ember-data/adapter/json-api                      | 897.00 B  | 193.05 B   | 5.8           | 0.5
	@ember-data/adapter/index                         | 635.00 B  | 136.66 B   | 4.1           | 0.4

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '13.59 KB' │
│  compressed  │ '2.93 KB'  │
│ % Of Library │   '8.4'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 13.12 KB  | 2.82 KB    | 96.5          | 8.1
	@ember-data/model/index                           | 486.00 B  | 104.59 B   | 3.5           | 0.3

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.28 KB' │
│  compressed  │ '2.00 KB' │
│ % Of Library │   '5.7'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.32 KB   | 512.00 B   | 25.0          | 1.4
	ember-data/-private                               | 2.02 KB   | 446.15 B   | 21.8          | 1.3
	ember-data/adapters/errors                        | 1.19 KB   | 261.92 B   | 12.8          | 0.7
	ember-data/setup-container                        | 503.00 B  | 108.25 B   | 5.3           | 0.3
	ember-data/relationships                          | 318.00 B  | 68.43 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 58.97 B    | 2.9           | 0.2
	ember-data/serializers/json-api                   | 251.00 B  | 54.02 B    | 2.6           | 0.2
	ember-data/adapters/json-api                      | 245.00 B  | 52.72 B    | 2.6           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 52.29 B    | 2.6           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 52.29 B    | 2.6           | 0.1
	ember-data/transform                              | 241.00 B  | 51.86 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 51.00 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 49.93 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 48.63 B    | 2.4           | 0.1
	ember-data/model                                  | 222.00 B  | 47.77 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 47.77 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 46.91 B    | 2.3           | 0.1
	ember-data/version                                | 162.00 B  | 34.86 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '7.91 KB' │
│  compressed  │ '1.70 KB' │
│ % Of Library │   '4.9'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.76 KB   | 608.42 B   | 34.9          | 1.7
	ember-inflector/lib/system/inflections            | 1.57 KB   | 346.50 B   | 19.9          | 1.0
	ember-inflector/index                             | 1.12 KB   | 247.07 B   | 14.2          | 0.7
	ember-inflector/lib/ext/string                    | 783.00 B  | 168.51 B   | 9.7           | 0.5
	ember-inflector/lib/system                        | 452.00 B  | 97.27 B    | 5.6           | 0.3
	ember-inflector/lib/system/string                 | 351.00 B  | 75.54 B    | 4.3           | 0.2
	ember-inflector/lib/helpers/pluralize             | 348.00 B  | 74.89 B    | 4.3           | 0.2
	ember-inflector/lib/utils/make-helper             | 308.00 B  | 66.28 B    | 3.8           | 0.2
	ember-inflector/lib/helpers/singularize           | 271.00 B  | 58.32 B    | 3.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.70 KB'  │
│  compressed  │ '595.08 B' │
│ % Of Library │   '1.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.21 KB   | 487.68 B   | 82.0          | 1.4
	@ember-data/debug/setup                           | 499.00 B  | 107.39 B   | 18.0          | 0.3

Package: @ember/ordered-set
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '1.08 KB'  │
│  compressed  │ '237.38 B' │
│ % Of Library │   '0.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember/ordered-set/index                          | 1.08 KB   | 237.38 B   | 100.0         | 0.7

Modern Builds

EmberData shrank by 71.0 B (-22.0 B compressed)

If any packages had changed sizes they would be listed here.

Changeset


EmberData 161.64 KB -71.0 B (34.79 KB +22.0 B compressed)
    @ember-data/store 70.05 KB -71.0 B (15.08 KB +22.0 B compressed)
        @ember-data/store/-private 69.14 KB -71.0 B (14.88 KB +22.0 B compressed)

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '161.64 KB' │
│ compressed │ '34.79 KB'  │
│  packages  │      9      │
│  modules   │     46      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '70.05 KB' │
│  compressed  │ '15.08 KB' │
│ % Of Library │   '43.3'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 69.14 KB  | 14.88 KB   | 98.7          | 42.8
	@ember-data/store/index                           | 936.00 B  | 201.44 B   | 1.3           | 0.6

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.65 KB' │
│  compressed  │ '4.87 KB'  │
│ % Of Library │   '14.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 22.65 KB  | 4.87 KB    | 100.0         | 14.0

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.37 KB' │
│  compressed  │ '4.17 KB'  │
│ % Of Library │   '12.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.12 KB   | 1.53 KB    | 36.8          | 4.4
	@ember-data/serializer/-private                   | 5.37 KB   | 1.16 KB    | 27.7          | 3.3
	@ember-data/serializer/json-api                   | 3.72 KB   | 819.12 B   | 19.2          | 2.3
	@ember-data/serializer/rest                       | 2.71 KB   | 597.88 B   | 14.0          | 1.7
	@ember-data/serializer/index                      | 243.00 B  | 52.29 B    | 1.2           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 46.27 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.02 KB' │
│  compressed  │ '3.23 KB'  │
│ % Of Library │   '9.3'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 8.03 KB   | 1.73 KB    | 53.5          | 5.0
	@ember-data/adapter/-private                      | 3.58 KB   | 787.92 B   | 23.8          | 2.2
	@ember-data/adapter/error                         | 1.91 KB   | 421.61 B   | 12.7          | 1.2
	@ember-data/adapter/json-api                      | 897.00 B  | 193.05 B   | 5.8           | 0.5
	@ember-data/adapter/index                         | 635.00 B  | 136.66 B   | 4.1           | 0.4

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '13.59 KB' │
│  compressed  │ '2.93 KB'  │
│ % Of Library │   '8.4'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 13.12 KB  | 2.82 KB    | 96.5          | 8.1
	@ember-data/model/index                           | 486.00 B  | 104.59 B   | 3.5           | 0.3

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.28 KB' │
│  compressed  │ '2.00 KB' │
│ % Of Library │   '5.7'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.32 KB   | 512.00 B   | 25.0          | 1.4
	ember-data/-private                               | 2.02 KB   | 446.15 B   | 21.8          | 1.3
	ember-data/adapters/errors                        | 1.19 KB   | 261.92 B   | 12.8          | 0.7
	ember-data/setup-container                        | 503.00 B  | 108.25 B   | 5.3           | 0.3
	ember-data/relationships                          | 318.00 B  | 68.43 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 58.97 B    | 2.9           | 0.2
	ember-data/serializers/json-api                   | 251.00 B  | 54.02 B    | 2.6           | 0.2
	ember-data/adapters/json-api                      | 245.00 B  | 52.72 B    | 2.6           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 52.29 B    | 2.6           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 52.29 B    | 2.6           | 0.1
	ember-data/transform                              | 241.00 B  | 51.86 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 51.00 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 49.93 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 48.63 B    | 2.4           | 0.1
	ember-data/model                                  | 222.00 B  | 47.77 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 47.77 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 46.91 B    | 2.3           | 0.1
	ember-data/version                                | 162.00 B  | 34.86 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '7.91 KB' │
│  compressed  │ '1.70 KB' │
│ % Of Library │   '4.9'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.76 KB   | 608.42 B   | 34.9          | 1.7
	ember-inflector/lib/system/inflections            | 1.57 KB   | 346.50 B   | 19.9          | 1.0
	ember-inflector/index                             | 1.12 KB   | 247.07 B   | 14.2          | 0.7
	ember-inflector/lib/ext/string                    | 783.00 B  | 168.51 B   | 9.7           | 0.5
	ember-inflector/lib/system                        | 452.00 B  | 97.27 B    | 5.6           | 0.3
	ember-inflector/lib/system/string                 | 351.00 B  | 75.54 B    | 4.3           | 0.2
	ember-inflector/lib/helpers/pluralize             | 348.00 B  | 74.89 B    | 4.3           | 0.2
	ember-inflector/lib/utils/make-helper             | 308.00 B  | 66.28 B    | 3.8           | 0.2
	ember-inflector/lib/helpers/singularize           | 271.00 B  | 58.32 B    | 3.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.70 KB'  │
│  compressed  │ '595.08 B' │
│ % Of Library │   '1.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.21 KB   | 487.68 B   | 82.0          | 1.4
	@ember-data/debug/setup                           | 499.00 B  | 107.39 B   | 18.0          | 0.3

Package: @ember/ordered-set
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '1.08 KB'  │
│  compressed  │ '237.38 B' │
│ % Of Library │   '0.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember/ordered-set/index                          | 1.08 KB   | 237.38 B   | 100.0         | 0.7

Modern Builds (No Rollup)

EmberData shrank by 122.0 B (27.0 B compressed)

If any packages had changed sizes they would be listed here.

Changeset


EmberData 206.25 KB -122.0 B (39.29 KB -27.0 B compressed)
    @ember-data/store 102.65 KB -122.0 B (19.55 KB -27.0 B compressed)
        @ember-data/store/-private/system/model/internal-model 16.99 KB -2.0 B (3.24 KB -0.44 B compressed)
        @ember-data/store/-private/system/record-array-manager 4.45 KB -85.0 B (868.24 B -18.81 B compressed)
        @ember-data/store/-private/system/record-arrays/record-array 2.25 KB -16.0 B (438.69 B -3.54 B compressed)
        @ember-data/store/-private/system/references/reference 939.0 B -3.0 B (178.86 B -0.66 B compressed)
        @ember-data/store/-private/system/record-arrays/adapter-populated-record-array 892.0 B -16.0 B (169.91 B -3.54 B compressed)

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '206.25 KB' │
│ compressed │ '39.29 KB'  │
│  packages  │      9      │
│  modules   │     144     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬─────────────┐
│   (index)    │   Values    │
├──────────────┼─────────────┤
│    bytes     │ '102.65 KB' │
│  compressed  │ '19.55 KB'  │
│ % Of Library │   '49.8'    │
└──────────────┴─────────────┘
	Module                                                                             | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/system/core-store                                       | 17.55 KB  | 3.34 KB    | 17.1          | 8.5
	@ember-data/store/-private/system/model/internal-model                             | 16.99 KB  | 3.24 KB    | 16.6          | 8.2
	@ember-data/store/-private/system/model/states                                     | 5.44 KB   | 1.04 KB    | 5.3           | 2.6
	@ember-data/store/-private/system/fetch-manager                                    | 4.95 KB   | 965.01 B   | 4.8           | 2.4
	@ember-data/store/-private/system/record-array-manager                             | 4.45 KB   | 868.24 B   | 4.3           | 2.2
	@ember-data/store/-private/index                                                   | 4.44 KB   | 865.19 B   | 4.3           | 2.2
	@ember-data/store/-private/system/store/finders                                    | 4.35 KB   | 849.19 B   | 4.2           | 2.1
	@ember-data/store/-private/identifiers/cache                                       | 3.86 KB   | 753.18 B   | 3.8           | 1.9
	@ember-data/store/-private/system/store/record-data-store-wrapper                  | 3.42 KB   | 666.51 B   | 3.3           | 1.7
	@ember-data/store/-private/system/store/internal-model-factory                     | 2.91 KB   | 567.84 B   | 2.8           | 1.4
	@ember-data/store/-private/system/snapshot                                         | 2.85 KB   | 556.03 B   | 2.8           | 1.4
	@ember-data/store/-private/system/record-arrays/record-array                       | 2.25 KB   | 438.69 B   | 2.2           | 1.1
	@ember-data/store/-private/system/ds-model-store                                   | 1.99 KB   | 388.21 B   | 1.9           | 1.0
	@ember-data/store/-private/system/request-cache                                    | 1.89 KB   | 367.83 B   | 1.8           | 0.9
	@ember-data/store/-private/system/references/has-many                              | 1.51 KB   | 293.73 B   | 1.5           | 0.7
	@ember-data/store/-private/system/schema-definition-service                        | 1.47 KB   | 287.44 B   | 1.4           | 0.7
	@ember-data/store/-private/system/relationship-meta                                | 1.45 KB   | 282.30 B   | 1.4           | 0.7
	@ember-data/store/-private/system/model/shim-model-class                           | 1.27 KB   | 247.63 B   | 1.2           | 0.6
	@ember-data/store/-private/system/references/belongs-to                            | 1.24 KB   | 241.15 B   | 1.2           | 0.6
	@ember-data/store/-private/system/store/serializer-response                        | 1.12 KB   | 219.25 B   | 1.1           | 0.5
	@ember-data/store/-private/identifiers/utils/uuid-v4                               | 1.05 KB   | 205.34 B   | 1.0           | 0.5
	@ember-data/store/-private/system/internal-model-map                               | 983.00 B  | 187.24 B   | 0.9           | 0.5
	@ember-data/store/-private/system/references/record                                | 968.00 B  | 184.39 B   | 0.9           | 0.5
	@ember-data/store/-private/system/references/reference                             | 939.00 B  | 178.86 B   | 0.9           | 0.4
	@ember-data/store/index                                                            | 936.00 B  | 178.29 B   | 0.9           | 0.4
	@ember-data/store/-private/system/record-arrays/adapter-populated-record-array     | 892.00 B  | 169.91 B   | 0.8           | 0.4
	@ember-data/store/-private/system/model/notify-changes                             | 866.00 B  | 164.96 B   | 0.8           | 0.4
	@ember-data/store/-private/system/errors-utils                                     | 764.00 B  | 145.53 B   | 0.7           | 0.4
	@ember-data/store/-private/system/snapshot-record-array                            | 753.00 B  | 143.43 B   | 0.7           | 0.4
	@ember-data/store/-private/system/record-notification-manager                      | 689.00 B  | 131.24 B   | 0.7           | 0.3
	@ember-data/store/-private/system/references                                       | 598.00 B  | 113.91 B   | 0.6           | 0.3
	@ember-data/store/-private/system/promise-proxies                                  | 556.00 B  | 105.91 B   | 0.5           | 0.3
	@ember-data/store/-private/utils/construct-resource                                | 506.00 B  | 96.38 B    | 0.5           | 0.2
	@ember-data/store/-private/system/store/common                                     | 505.00 B  | 96.19 B    | 0.5           | 0.2
	@ember-data/store/-private/system/coerce-id                                        | 496.00 B  | 94.48 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-arrays                                    | 487.00 B  | 92.76 B    | 0.5           | 0.2
	@ember-data/store/-private/system/identity-map                                     | 450.00 B  | 85.71 B    | 0.4           | 0.2
	@ember-data/store/-private/system/diff-array                                       | 438.00 B  | 83.43 B    | 0.4           | 0.2
	@ember-data/store/-private/ts-interfaces/identifier                                | 400.00 B  | 76.19 B    | 0.4           | 0.2
	@ember-data/store/-private/utils/symbol                                            | 393.00 B  | 74.86 B    | 0.4           | 0.2
	@ember-data/store/-private/identifiers/is-stable-identifier                        | 327.00 B  | 62.28 B    | 0.3           | 0.2
	@ember-data/store/-private/ts-interfaces/fetch-manager                             | 316.00 B  | 60.19 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/promise-record                                    | 290.00 B  | 55.24 B    | 0.3           | 0.1
	@ember-data/store/-private/system/backburner                                       | 268.00 B  | 51.05 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/brand                                             | 258.00 B  | 49.14 B    | 0.2           | 0.1
	@ember-data/store/-private/system/record-data-for                                  | 235.00 B  | 44.76 B    | 0.2           | 0.1
	@ember-data/store/-private/system/ts-upgrade-map                                   | 234.00 B  | 44.57 B    | 0.2           | 0.1
	@ember-data/store/-private/system/normalize-model-name                             | 220.00 B  | 41.90 B    | 0.2           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                               | 212.00 B  | 40.38 B    | 0.2           | 0.1
	@ember-data/store/-debug/index                                                     | 193.00 B  | 36.76 B    | 0.2           | 0.1
	@ember-data/store/-private/system/deprecated-evented                               | 190.00 B  | 36.19 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-store-wrapper                 | 136.00 B  | 25.90 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-schemas                       | 130.00 B  | 24.76 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-serializer-interface              | 98.00 B   | 18.66 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data-record-wrapper                | 96.00 B   | 18.28 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/minimum-adapter-interface                 | 95.00 B   | 18.09 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/schema-definition-service                 | 95.00 B   | 18.09 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data-json-api                      | 90.00 B   | 17.14 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/ember-data-json-api                       | 89.00 B   | 16.95 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/promise-proxies                           | 85.00 B   | 16.19 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-instance                           | 85.00 B   | 16.19 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data                               | 81.00 B   | 15.42 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/ds-model                                  | 78.00 B   | 14.85 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/utils                                     | 75.00 B   | 14.28 B    | 0.1           | 0.0

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '26.07 KB' │
│  compressed  │ '4.97 KB'  │
│ % Of Library │   '12.6'   │
└──────────────┴────────────┘
	Module                                                                      | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/relationships/state/relationship           | 8.17 KB   | 1.56 KB    | 31.3          | 4.0
	@ember-data/record-data/-private/record-data                                | 8.12 KB   | 1.55 KB    | 31.1          | 3.9
	@ember-data/record-data/-private/relationships/state/belongs-to             | 3.02 KB   | 588.98 B   | 11.6          | 1.5
	@ember-data/record-data/-private/relationships/state/has-many               | 2.82 KB   | 549.93 B   | 10.8          | 1.4
	@ember-data/record-data/-private/relationships/state/create                 | 1.15 KB   | 224.77 B   | 4.4           | 0.6
	@ember-data/record-data/-private/index                                      | 1023.00 B | 194.86 B   | 3.8           | 0.5
	@ember-data/record-data/-private/ordered-set                                | 598.00 B  | 113.91 B   | 2.2           | 0.3
	@ember-data/record-data/-private/record-data-for                            | 481.00 B  | 91.62 B    | 1.8           | 0.2
	@ember-data/record-data/-private/coerce-id                                  | 406.00 B  | 77.33 B    | 1.5           | 0.2
	@ember-data/record-data/-private/normalize-link                             | 249.00 B  | 47.43 B    | 0.9           | 0.1
	@ember-data/record-data/-private/ts-interfaces/relationship-record-data     | 100.00 B  | 19.04 B    | 0.4           | 0.0

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '21.76 KB' │
│  compressed  │ '4.14 KB'  │
│ % Of Library │   '10.5'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.12 KB   | 1.36 KB    | 32.7          | 3.5
	@ember-data/serializer/-private/embedded-records-mixin     | 4.30 KB   | 838.52 B   | 19.8          | 2.1
	@ember-data/serializer/json-api                            | 3.72 KB   | 724.99 B   | 17.1          | 1.8
	@ember-data/serializer/rest                                | 2.71 KB   | 529.17 B   | 12.5          | 1.3
	@ember-data/serializer/-private/index                      | 1.18 KB   | 230.48 B   | 5.4           | 0.6
	@ember-data/serializer/-private/transforms/date            | 523.00 B  | 99.62 B    | 2.3           | 0.2
	@ember-data/serializer/-private/transforms/boolean         | 490.00 B  | 93.33 B    | 2.2           | 0.2
	@ember-data/serializer/-private/transforms/number          | 446.00 B  | 84.95 B    | 2.0           | 0.2
	@ember-data/serializer/-private/transforms/string          | 351.00 B  | 66.86 B    | 1.6           | 0.2
	@ember-data/serializer/-private/utils                      | 286.00 B  | 54.47 B    | 1.3           | 0.1
	@ember-data/serializer/index                               | 243.00 B  | 46.28 B    | 1.1           | 0.1
	@ember-data/serializer/-private/transforms/transform       | 242.00 B  | 46.09 B    | 1.1           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 40.95 B    | 1.0           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '17.53 KB' │
│  compressed  │ '3.34 KB'  │
│ % Of Library │   '8.5'    │
└──────────────┴────────────┘
	Module                                                   | Bytes     | Compressed | % of Package  | % Of Library
	------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                         | 6.32 KB   | 1.20 KB    | 36.0          | 3.1
	@ember-data/model/-private/system/many-array             | 2.40 KB   | 467.45 B   | 13.7          | 1.2
	@ember-data/model/-private/errors                        | 2.03 KB   | 396.59 B   | 11.6          | 1.0
	@ember-data/model/-private/index                         | 1.29 KB   | 251.63 B   | 7.4           | 0.6
	@ember-data/model/-private/system/relationships/ext      | 1.19 KB   | 232.58 B   | 6.8           | 0.6
	@ember-data/model/-private/attr                          | 724.00 B  | 137.91 B   | 4.0           | 0.3
	@ember-data/model/-private/belongs-to                    | 663.00 B  | 126.29 B   | 3.7           | 0.3
	@ember-data/model/-private/system/promise-many-array     | 642.00 B  | 122.29 B   | 3.6           | 0.3
	@ember-data/model/-private/has-many                      | 626.00 B  | 119.24 B   | 3.5           | 0.3
	@ember-data/model/index                                  | 486.00 B  | 92.57 B    | 2.7           | 0.2
	@ember-data/model/-private/util                          | 442.00 B  | 84.19 B    | 2.5           | 0.2
	@ember-data/model/-private/system/promise-belongs-to     | 412.00 B  | 78.48 B    | 2.3           | 0.2
	@ember-data/model/-private/system/model-for-mixin        | 408.00 B  | 77.71 B    | 2.3           | 0.2

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '17.06 KB' │
│  compressed  │ '3.25 KB'  │
│ % Of Library │   '8.3'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 8.03 KB   | 1.53 KB    | 47.1          | 3.9
	@ember-data/adapter/error                                     | 1.91 KB   | 373.16 B   | 11.2          | 0.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.81 KB   | 353.92 B   | 10.6          | 0.9
	@ember-data/adapter/-private/index                            | 1.03 KB   | 201.15 B   | 6.0           | 0.5
	@ember-data/adapter/json-api                                  | 897.00 B  | 170.86 B   | 5.1           | 0.4
	@ember-data/adapter/-private/utils/serialize-query-params     | 792.00 B  | 150.86 B   | 4.5           | 0.4
	@ember-data/adapter/index                                     | 635.00 B  | 120.95 B   | 3.6           | 0.3
	@ember-data/adapter/-private/utils/determine-body-promise     | 549.00 B  | 104.57 B   | 3.1           | 0.3
	@ember-data/adapter/-private/utils/parse-response-headers     | 480.00 B  | 91.43 B    | 2.7           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 454.00 B  | 86.48 B    | 2.6           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 347.00 B  | 66.09 B    | 2.0           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 219.00 B  | 41.71 B    | 1.3           | 0.1

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.50 KB' │
│  compressed  │ '1.81 KB' │
│ % Of Library │   '4.6'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.32 KB   | 453.16 B   | 24.5          | 1.1
	ember-data/-private/index                         | 1.93 KB   | 376.02 B   | 20.3          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 231.82 B   | 12.5          | 0.6
	ember-data/setup-container                        | 503.00 B  | 95.81 B    | 5.2           | 0.2
	ember-data/-private/core                          | 321.00 B  | 61.14 B    | 3.3           | 0.2
	ember-data/relationships                          | 318.00 B  | 60.57 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 52.19 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 47.81 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 46.66 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 46.28 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 46.28 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 45.90 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 45.14 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 44.19 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 43.05 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 42.28 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 42.28 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 41.52 B    | 2.2           | 0.1
	ember-data/version                                | 162.00 B  | 30.85 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '7.91 KB' │
│  compressed  │ '1.51 KB' │
│ % Of Library │   '3.8'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.76 KB   | 538.50 B   | 34.9          | 1.3
	ember-inflector/lib/system/inflections            | 1.57 KB   | 306.68 B   | 19.9          | 0.8
	ember-inflector/index                             | 1.12 KB   | 218.67 B   | 14.2          | 0.5
	ember-inflector/lib/ext/string                    | 783.00 B  | 149.15 B   | 9.7           | 0.4
	ember-inflector/lib/system                        | 452.00 B  | 86.09 B    | 5.6           | 0.2
	ember-inflector/lib/system/string                 | 351.00 B  | 66.86 B    | 4.3           | 0.2
	ember-inflector/lib/helpers/pluralize             | 348.00 B  | 66.28 B    | 4.3           | 0.2
	ember-inflector/lib/utils/make-helper             | 308.00 B  | 58.66 B    | 3.8           | 0.1
	ember-inflector/lib/helpers/singularize           | 271.00 B  | 51.62 B    | 3.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.70 KB'  │
│  compressed  │ '526.69 B' │
│ % Of Library │   '1.3'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.21 KB   | 431.63 B   | 82.0          | 1.1
	@ember-data/debug/setup                           | 499.00 B  | 95.05 B    | 18.0          | 0.2

Package: @ember/ordered-set
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '1.08 KB'  │
│  compressed  │ '210.10 B' │
│ % Of Library │   '0.5'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember/ordered-set/index                          | 1.08 KB   | 210.10 B   | 100.0         | 0.5

snewcomer · 2020-12-03T05:23:51Z

A few possible paths here. 1 - we could consider this feature flag done and any further work to remove internalModel could be under new feature flags. 2 - close this PR and find more spots to remove internalModel (core store?).

One reason we might consider this feature flag completed is because we have ✂️ the use of internalModel in record-array and associated modules.

This reverts commit 991e96f.

igorT · 2020-12-03T14:04:24Z

packages/canary-features/addon/default-features.ts

@@ -177,6 +177,5 @@ export default {
  REQUEST_SERVICE: null,
  CUSTOM_MODEL_CLASS: null,
  FULL_LINKS_ON_RELATIONSHIPS: true,
-  RECORD_ARRAY_MANAGER_IDENTIFIERS: true,
  REMOVE_RECORD_ARRAY_MANAGER_LEGACY_COMPAT: null,


We probably want to keep the flag exposed

igorT · 2020-12-03T14:04:32Z

packages/canary-features/addon/index.ts

@@ -38,7 +38,6 @@ export const REQUEST_SERVICE = featureValue(FEATURES.REQUEST_SERVICE);
 export const IDENTIFIERS = featureValue(FEATURES.IDENTIFIERS);
 export const CUSTOM_MODEL_CLASS = featureValue(FEATURES.CUSTOM_MODEL_CLASS);
 export const FULL_LINKS_ON_RELATIONSHIPS = featureValue(FEATURES.FULL_LINKS_ON_RELATIONSHIPS);


We probably want to keep the flag exposed

igorT · 2020-12-05T01:05:09Z

packages/store/addon/-private/system/references/reference.ts

@@ -32,15 +32,10 @@ function isResourceIdentiferWithRelatedLinks(
  return value && value.links && value.links.related;
 }

-// TODO: simplify after 3.23 release and only store identifier
-export const REFERENCE_CACHE = new WeakMap<Reference, InternalModel | StableRecordIdentifier>();
+export const REFERENCE_CACHE = new WeakMap<Reference, StableRecordIdentifier>();


Thanks for the cleanup

igorT · 2020-12-05T01:06:08Z

@snewcomer we should use a new feature flag for new units of work, so they are easier to back out of. A lot of cleanup might not even need it, depending on how risky it is

[Cleanup]: Remove RECORD_ARRAY_MANAGER_IDENTIFIERS

d072f5e

snewcomer added the Feature label Dec 3, 2020

snewcomer self-assigned this Dec 3, 2020

fix doc tests

9e1ce7a

snewcomer requested a review from igorT December 3, 2020 04:46

more cleanup

991e96f

snewcomer added blocked and removed Feature labels Dec 3, 2020

Ensure WeakMap used in references is only typed for identifiers

96f3449

Revert "more cleanup"

5edf62c

This reverts commit 991e96f.

snewcomer added Feature and removed blocked labels Dec 3, 2020

igorT reviewed Dec 3, 2020

View reviewed changes

keep flag exposed

eb2a192

igorT reviewed Dec 5, 2020

View reviewed changes

igorT merged commit 7756aed into master Dec 5, 2020

delete-merged-branch bot deleted the sn/rm-record-array-manager-identifiers branch December 5, 2020 01:07

locks mentioned this pull request Feb 19, 2021

Ember 3.25 Release ember-learn/ember-blog#914

Merged

dependabot bot mentioned this pull request Mar 15, 2021

chore(deps-dev): bump ember-data from 3.17.0 to 3.25.0 movableink/ember-data-json-api-bulk-ext#157

Closed

runspired added 🏷️ feat This PR introduces a new feature and removed Feature labels Sep 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cleanup]: Remove RECORD_ARRAY_MANAGER_IDENTIFIERS #7394

[Cleanup]: Remove RECORD_ARRAY_MANAGER_IDENTIFIERS #7394

snewcomer commented Dec 3, 2020

github-actions bot commented Dec 3, 2020 •

edited

Loading

github-actions bot commented Dec 3, 2020 •

edited

Loading

snewcomer commented Dec 3, 2020

igorT Dec 3, 2020

igorT Dec 3, 2020

igorT Dec 5, 2020

igorT commented Dec 5, 2020

[Cleanup]: Remove RECORD_ARRAY_MANAGER_IDENTIFIERS #7394

[Cleanup]: Remove RECORD_ARRAY_MANAGER_IDENTIFIERS #7394

Conversation

snewcomer commented Dec 3, 2020

github-actions bot commented Dec 3, 2020 • edited Loading

github-actions bot commented Dec 3, 2020 • edited Loading

snewcomer commented Dec 3, 2020

igorT Dec 3, 2020

Choose a reason for hiding this comment

igorT Dec 3, 2020

Choose a reason for hiding this comment

igorT Dec 5, 2020

Choose a reason for hiding this comment

igorT commented Dec 5, 2020

github-actions bot commented Dec 3, 2020 •

edited

Loading

github-actions bot commented Dec 3, 2020 •

edited

Loading