Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Entangle Errors.errorsFor properly #7273

Merged
merged 1 commit into from
Aug 23, 2020
Merged

[BUGFIX] Entangle Errors.errorsFor properly #7273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions packages/model/addon/-private/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,11 +127,20 @@ export default ArrayProxy.extend(DeprecatedEvented, {
errorsFor(attribute) {
let map = get(this, 'errorsByAttributeName');

if (!map.has(attribute)) {
map.set(attribute, A());
let errors = map.get(attribute);

if (errors === undefined) {
errors = A();
map.set(attribute, errors);
}

return map.get(attribute);
// Errors may be a native array with extensions turned on. Since we access
// the array via a method, and not a computed or using `Ember.get`, it does
// not entangle properly with autotracking, so we entangle manually by
// getting the `[]` property.
get(errors, '[]');

return errors;
},

/**
Expand Down