Silence warnings and deprecations in the console during tests #4663
Conversation
|
just checking but this doesn't only silence them, but asserts they do or do not happen & happens to silence them right? |
There was a problem hiding this comment.
Honestly I am not super happy about ignoring the deprecations. I think the desired approach here would be to expect a warning in every test which actually uses "to be deprecated" behavior.
Or am I missing something?
Basically ❤️ 👍 for making the test output less noisy! Thanks for working on this!
| @@ -836,7 +836,7 @@ test("the promise returned by `_scheduleFetch`, when it rejects, does not depend | |||
| }); | |||
|
|
|||
| test("store._fetchRecord reject records that were not found, even when those requests were coalesced with records that were found", function(assert) { | |||
I added 2 assertions that happens to silence the warnings mainly for the side effect of silencing the warnings. The json-serializer-test.js did not have an existing test for the warning, however the adapter-interop-test does have an explicit test for the warning which my change now duplicates. For the since almost all of the tests in the errors object trigger a warning I overrode Ember.warn for that entire module. I also added an ignoreDeprecation in the rest-adapter-test.js which doesn't and any assertions since there is already a test for that deprecation |
|
Although a pain, I think the ideal is. error on unexpected warn, error on unexpected deprecation. And require assertions in those places. Maybe there is a middleground, but hiding warning/deprecations is a slippery slope. |
|
We had this once (added in #3834) but somehow this isn't working anymore. At least not the last time I checked (if I remember correctly). |
|
I have updated this pr to explicitly tests for all of the deprecations and warnings that were ignored in the earlier version of this pr. @pangratz enabling that flag now causes the build to fail when there is a deprecation warning. |
| @@ -2,7 +2,7 @@ | |||
| import Ember from 'ember'; | |||
| import EmberTestHelpers from "ember-dev/test-helper/index"; | |||
|
|
|||
| const AVAILABLE_ASSERTIONS = ['expectAssertion', 'expectDeprecation', 'expectNoDeprecation', 'expectWarning', 'expectNoWarning']; | |||
| const AVAILABLE_ASSERTIONS = ['expectAssertion', 'expectDeprecation', 'expectNoDeprecation', 'expectWarning', 'expectNoWarning', 'ignoreDeprecation']; | |||
There was a problem hiding this comment.
Seems like ignoreDeprecation is no more used?
There was a problem hiding this comment.
Hmm, nevermind. I think it doesn't hurt if this assertion is available too.
|
Thanks for your work in this @bmac!! 🚀 |
Closes #4416
Before
After