Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only remove deleted records form record arrays when saved #3539

Merged
merged 3 commits into from
Jul 18, 2015
Merged

Only remove deleted records form record arrays when saved #3539

merged 3 commits into from
Jul 18, 2015

Commits on Jul 13, 2015

  1. Don't remove records from record arrays before commiting 

    Before this commit records were deleted from record arrays just after
deleting them, but before they were commited. This can be an issue if
you want to keep records visible in the UI until they're actually
removed.
    @drogus @bmac
    drogus authored and bmac committed Jul 13, 2015
    Configuration menu
    Copy the full SHA
    529f959 View commit details
    Browse the repository at this point in the history

  2. Clean up logic to only remove records in the 'deleted.saved' state.

    @bmac
    bmac committed Jul 13, 2015
    Configuration menu
    Copy the full SHA
    a570eca View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2015

  1. Rebase and test cleanup for @drogus work on keeping records after del… 

    …eteRecord

- Removed disconnectRelationship method calls from model/states.js
- Removed reconnectRelationships from modle/internal-model.js
- Remove one-sided disconnect and reconnect relationship methods
- Removed method definitions in internal-model for:
  - disconnectRelationships
  - reconnectRelationships
- Removed method definitions in relationship for:
  - disconnect
  - reconnect
  - addRecordToInverse
- Fixed incorrect tests
    @ianstarz @bmac
    ianstarz authored and bmac committed Jul 14, 2015
    Configuration menu
    Copy the full SHA
    d2ba097 View commit details
    Browse the repository at this point in the history