Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont remove deleted but uncommited records from record arrays #3247

Closed
wants to merge 2 commits into from
Closed

Dont remove deleted but uncommited records from record arrays #3247

wants to merge 2 commits into from

Commits on Jun 16, 2015

  1. Don't remove records from record arrays before commiting 

    Before this commit records were deleted from record arrays just after
deleting them, but before they were commited. This can be an issue if
you want to keep records visible in the UI until they're actually
removed.
    @drogus @ianstarz
    drogus authored and ianstarz committed Jun 16, 2015
    Configuration menu
    Copy the full SHA
    74d3dec View commit details
    Browse the repository at this point in the history

  2. Rebase and test cleanup for @drogus work on keeping records after del… 

    …eteRecord

- Removed disconnectRelationship method calls from model/states.js
- Removed reconnectRelationships from modle/internal-model.js
- Remove one-sided disconnect and reconnect relationship methods
- Removed method definitions in internal-model for:
  - disconnectRelationships
  - reconnectRelationships
- Removed method definitions in relationship for:
  - disconnect
  - reconnect
  - addRecordToInverse
- Fixed incorrect tests
    @ianstarz
    ianstarz committed Jun 16, 2015
    Configuration menu
    Copy the full SHA
    a8599de View commit details
    Browse the repository at this point in the history