Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store.query and store.queryRecord should namespace query options #3453

Closed
igorT opened this issue Jun 26, 2015 · 8 comments
Closed

store.query and store.queryRecord should namespace query options #3453

igorT opened this issue Jun 26, 2015 · 8 comments

Comments

@igorT
Copy link
Member

igorT commented Jun 26, 2015

In particular, currently you call store.query('type', { options }), but it should be store.query('type', { query : {options} })

@thaume
Copy link

thaume commented Jun 26, 2015

Need help on that ?

On Fri, Jun 26, 2015, 19:21 Igor Terzic [email protected] wrote:

In particular, currently you call store.query('type', { options }), but
it should be store.query('type', { query : {options} })


Reply to this email directly or view it on GitHub
#3453.

@igorT
Copy link
Member Author

igorT commented Jun 26, 2015

Yes please, do you have time?

@igorT
Copy link
Member Author

igorT commented Jun 26, 2015

Raised it in the community slack

@thaume
Copy link

thaume commented Jun 26, 2015

Okay, yep I'll work on it on sunday night (long trip home)

On Fri, Jun 26, 2015, 20:21 Igor Terzic [email protected] wrote:

Raised it in the community slack


Reply to this email directly or view it on GitHub
#3453 (comment).

@igorT
Copy link
Member Author

igorT commented Jun 27, 2015

Sounds great

@thaume
Copy link

thaume commented Jun 29, 2015

Hey @igorT the PR is up over here #3459

@e00dan
Copy link
Contributor

e00dan commented Sep 24, 2015

What's the status of this issue?

@bmac
Copy link
Member

bmac commented Dec 23, 2015

This change didn't end up making it into 2.0. I'm going to close it because we are unlikely to add a breaking change like this until 3.0.

@bmac bmac closed this as completed Dec 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants