-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create pull_request_template.md #522
base: master
Are you sure you want to change the base?
Conversation
Adding a pull request template to make meeting facilitation easier .
TODO: | ||
- [ ] Review new comments or feedback in the RFC, and the checklist in each PR description. | ||
- [ ] Determine if there are any new actions to take, or if any checkboxes have been completed. | ||
- [ ] Update this document with notes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds like this template pertains only to the RFC review meetings. I think we had said that we wouldn't be taking notes for those meetings but would record outcomes on the particular RFCs. Am I remembering that correctly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems fair but also then makes me wonder if there's a point to having notes at all if we're not going to write down what was reviewed/discussed?
WDYT?
1. Standing items: should happen every meeting | ||
2. Additional discussion: for any other topic to be discussed | ||
|
||
#### Standing Item: General Admin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this make sense in the RFC review meeting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's something we can decide, I think. I thought it could make sense to at least have this touchpoint in different timezones to help surface urgent issues a little more easily. It could also make sense to leave it out, so whatever we decide! 👍
If merged, this PR would add a pull request template to simplify and standardize meeting facilitation.
Note: The template starts with an
h2
element because the title of the page is already anh1
.