Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix side effecting ember cli htmlbars import #7

Conversation

NullVoxPopuli
Copy link
Contributor

rollup & co will try to optimize our v2 addons for runtime by hoisting the ember-cli-htmlbars to the toppest entry module.

during an app's build time, we need to remove that.

@ef4
Copy link
Contributor

ef4 commented Jul 14, 2022

We discussed this during embroider office hours and concluded that hoistTransitiveImports is a better solution. This plugin doesn't support side-effectful import of ember-cli-htmlbars because it doesn't mean anything, so we can stop rollup from adding that. In general we don't want rollup to try to do this kind of whole-app optimization when we are merely building a v2 addon for publication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants