Fix ember-template-recast bin script file selection for Windows users
#147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
globby uses the fast-glob package, which states this in its README (RE: patterns): >⚠️ Always use forward-slashes in glob expressions (patterns and ignore > option). Use backslashes for escaping characters. Previously, we were using `path.join` which will use the OS specific separator and therefore fail to match files when invoked with a directory path directly. globby has an explicit API that allows us to avoid doing this `path.join` at all (`expandDirectories`). This changes to use that, remove the manual joining. --- This also corrects for a bug in globby (to be reported/fixed separately) where the `cwd` option is defaulted to `process.cwd()` _without_ posix correction, and then subsequently an assertion is made that a given path "starts with" the cwd.
4 tasks
rwjblue
changed the title
rwjblue
changed the title
ember-template-recast bin script file selection for Windows users
This was referenced Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
globby uses the fast-glob package, which states this in its README (RE:
patterns):
Previously, we were using
path.joinwhich will use the OS specificseparator and therefore fail to match files when invoked with a
directory path directly.
globby has an explicit API that allows us to avoid doing this
path.joinat all (expandDirectories). This changes to use that,remove the manual joining.
This also corrects for a bug in globby (to be reported/fixed separately)
where the
cwdoption is defaulted toprocess.cwd()without posixcorrection, and then subsequently an assertion is made that a given path
"starts with" the cwd.