Ensuring we pass node and/or line, column, endLine, endColumn to log #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scalvert
added
bug
dcyriller
approved these changes
Nov 9, 2021
|
FYI I pushed another commit to get a higher fidelity for |
|
Thanks for the improvement! I figured it'd be easier for you to determine the appropriate endLine/endColumn since you have a more clear idea of the expected output. |
|
Yes exactly! And I was a bit unsure if I could this.log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #175.
We should determine whether it's adequate to pass
line/columnasendLine/endColumnfor the differences, as it's not clear to me if higher fidelityendLine/endColumnis necessary here.This change should be backwards compatible with older versions, since passing node and/or
endLine/endColumnshould be considered "safe", even in older versions.