Skip to content

fix: remove implicit-modifier-manager-capabilities deprecation #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2020
Merged

fix: remove implicit-modifier-manager-capabilities deprecation #289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions addon/modifiers/on.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import { deprecate } from '@ember/application/deprecations';
import { assert } from '@ember/debug';
import { setModifierManager } from '@ember/modifier';
import { capabilities, setModifierManager } from '@ember/modifier';
import { DEBUG } from '@glimmer/env';

import { addEventListener, removeEventListener } from '../utils/event-listener';
Expand All @@ -22,7 +22,7 @@ const assertValidEventOptions =
const ALLOWED_EVENT_OPTIONS = ['capture', 'once', 'passive'];
const joinOptions = options => options.map(o => `'${o}'`).join(', ');

return function(eventOptions, eventName) {
return function (eventOptions, eventName) {
const invalidOptions = Object.keys(eventOptions).filter(
o => !ALLOWED_EVENT_OPTIONS.includes(o)
);
Expand Down Expand Up @@ -61,7 +61,7 @@ function setupListener(element, eventName, callback, eventOptions, params) {

if (Array.isArray(params) && params.length > 0) {
const _callback = callback;
callback = function(...args) {
callback = function (...args) {
return _callback.call(this, ...params, ...args);
};
}
Expand All @@ -81,6 +81,9 @@ function destroyListener(element, eventName, callback, eventOptions) {

export default setModifierManager(
() => ({

capabilities: capabilities('3.13'),

createModifier() {
return {
element: null,
Expand Down Expand Up @@ -142,5 +145,5 @@ export default setModifierManager(
destroyListener(element, eventName, callback, eventOptions);
}
}),
class OnModifier {}
class OnModifier { }
);