Merge pull request #7 from spencer516/factory-arg-fix

Pass result of `factoryFor`
ember-polyfills · Mar 2, 2019 · 6975c69 · 6975c69
2 parents dc296ef + 9ef46e6
commit 6975c69
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 3 deletions.
diff --git a/tests/integration/components/modifier-manager-test.js b/tests/integration/components/modifier-manager-test.js
@@ -27,6 +27,30 @@ module('Integration | Component | modifier-manager', function(hooks) {
     });
   });
 
+  module('createModifier', function() {
+    test('it passes the `factoryFor` definition', async function(assert) {
+      assert.expect(1);
+
+      class MyModifier {}
+
+      this.owner.register('modifier:my-modifier', MyModifier);
+
+      Ember._setModifierManager(
+        () => ({
+          createModifier(factory) {
+            assert.equal(factory.class, MyModifier, 'the factory class is Modifier');
+          },
+          installModifier() {},
+          updateModifier() {},
+          destroyModifier() {},
+        }),
+        MyModifier
+      );
+
+      await render(hbs`<div {{my-modifier}}></div>`);
+    });
+  });
+
   module('installModifier', function(hooks) {
     hooks.beforeEach(function() {
       class DidInsertModifier {}

diff --git a/vendor/ember-modifier-manager-polyfill.js b/vendor/ember-modifier-manager-polyfill.js
@@ -157,9 +157,9 @@ import { lte, gte } from 'ember-compatibility-helpers';
                 let manager = managerFactory(owner);
 
                 if (gte('3.6.0-alpha.1')) {
-                  return new Polyfilled_CustomModifierDefinition(name, modifier.class, manager);
+                  return new Polyfilled_CustomModifierDefinition(name, modifier, manager);
                 } else {
-                  return new Polyfilled_CustomModifierManagerLt36(name, modifier.class, manager);
+                  return new Polyfilled_CustomModifierManagerLt36(name, modifier, manager);
                 }
               }
             }
@@ -205,7 +205,7 @@ import { lte, gte } from 'ember-compatibility-helpers';
                 let managerFactory = getModifierManager(modifier.class);
                 let manager = managerFactory(owner);
 
-                return new Polyfilled_CustomModifierManagerLt36(name, modifier.class, manager);
+                return new Polyfilled_CustomModifierManagerLt36(name, modifier, manager);
               }
             }