Ensure polyfill works for Engines #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added another commit that fixes the "prettier" errors that came up in CI. Oddly, I didn't get them locally (in my local setup, prettier tells me to do the opposite of what the CI run wanted me to do). This passes in CI at least... |
|
Thank you @pgengler |
rwjblue
reviewed
May 28, 2020
| }); | ||
| return registry; | ||
| }; | ||
| for (const PolyfillTarget of [Application, Engine]) { |
There was a problem hiding this comment.
Sadly, I don't think we can use for of loops (because it ends up requiring Symbol which is not available on IE11), would you mind rewriting as either a plain for or .forEach?
There was a problem hiding this comment.
Done... rather than replace it with a different loop I just unrolled it, since it was only two elements.
rwjblue
approved these changes
Jun 5, 2020
rwjblue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated version of the changes in #48, to fix #47. Like that PR, it applies the polyfill to both Ember.Application and Ember.Engine; since Ember.Application extends from Ember.Engine this might be unnecessary and the polyfill need only be applied to Ember.Engine, but this way is unlikely to break anything. (Happy to update the PR if it's preferable to just apply to Ember.Engine.)
There aren't a lot of non-whitespace changes here; you might want to use Github's "Hide whitespace changes" feature to see the substantive changes.