Include polyfill for Ember 3.4 #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twokul
force-pushed
the
twokul/splattrs
branch
3 times, most recently
from
8cc6f98
to
3d1be40
Compare
|
Travis is running out of credits so we've switched to GitHub Actions for PRs too.
https://app.travis-ci.com/github/ember-polyfills/ember-angle-bracket-invocation-polyfill/requests |
twokul
force-pushed
the
twokul/splattrs
branch
4 times, most recently
from
e2e8ee6
to
f0f9eab
Compare
This is a more conservative version of the existing PR: ember-polyfills#123. In Ember 3.4 (w/o the polyfill), angle-bracket invocations do not work properly in some cases. For example: - `<FooBar class="some-class" />` - `<FooBar data-test="some-data-test" />`
|
Fortunately, Ember 3.4 is passing. Ember 3.8 and Ember 3.28 are failing on two link-to related tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more conservative version of the existing PR: #123.
In Ember 3.4 (w/o the polyfill), angle-bracket invocations do not work properly in some cases. For example:
<FooBar class="some-class" /><FooBar data-test="some-data-test" />