WIP Octane upgrade #123
WIP Octane upgrade #123
Conversation
Upgrading to this first should make it easier to upgrade to Octane.
|
We determined in chat that the issue was that we need to enable jquery |
vaidehijoshi
force-pushed
the
octane-upgrade
branch
from
0b47953 to
502e9a5
Compare
Using the ember-octane-blueprint from ember-cli.
We need it to be enabled because some of the dependencies in this app still use jquery.
vaidehijoshi
force-pushed
the
octane-upgrade
branch
from
1a3b013 to
b707dae
Compare
| "ember-qunit": "^3.4.1", | ||
| "ember-resolver": "^5.0.1", | ||
| "ember-qunit": "^4.1.2", | ||
| "ember-resolver": "^5.1.3", | ||
| "ember-simple-leaflet-maps": "^0.0.2", |
There was a problem hiding this comment.
I think if we update this, we shouldn't need jQuery (unless there is another plugin that is requiring it)
Crosslinking from ember-learn/ember-simple-leaflet-maps#2
|
Update on this: @wycats and I are pairing on this together and taking another approach. We're building the super-rentals app from scratch using the Octane blueprint and making note of our steps along the way that we can use for the upgrade guide once we have a completely idiomatic version of the super-rentals app. |
|
@vaidehijoshi @wycats any updates? |
|
We still have a bit more work to do on the app, but not too much more. We should hopefully be able to pair on it for another hour or two next week and get the Octane-idiomatic version of super-rentals wrapped up! (cc @wycats) |
No description provided.