Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML Attributes vs Component Arguments #1296

Merged
merged 5 commits into from
Mar 4, 2020
Merged

HTML Attributes vs Component Arguments #1296

merged 5 commits into from
Mar 4, 2020

Conversation

MichalBryxi
Copy link
Contributor

@MichalBryxi MichalBryxi commented Feb 8, 2020 •
edited
Loading

  • This PR touches only section on built-in-components.
  • If we're talking about components arguments AND the property name is in backticks, make sure there is always @ symbol in front of the argument name.
  • If we're talking about property that can be expressed as a HTML attribute, make sure we are not using @ symbol in front of the attribute name.

fix for: #1286

@MichalBryxi MichalBryxi mentioned this pull request Feb 8, 2020
Closed
MelSumner
MelSumner approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this work! 👍

@MelSumner MelSumner merged commit 42c7c30 into ember-learn:master Mar 4, 2020
@jamescdavis jamescdavis mentioned this pull request Apr 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MelSumner MelSumner MelSumner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichalBryxi @MelSumner