Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport replacing first and last names in code examples (Part 1 of 3) #1553

Closed
2 tasks
ijlee2 opened this issue Oct 8, 2020 · 5 comments · Fixed by #1568
Closed
2 tasks

Backport replacing first and last names in code examples (Part 1 of 3) #1553

ijlee2 opened this issue Oct 8, 2020 · 5 comments · Fixed by #1568
Assignees
@fozy81
Labels
good first issue Good for newcomers Hacktoberfest Issue counts towards Hacktoberfest help wanted Extra attention is needed

Comments

@ijlee2
Copy link
Member

ijlee2 commented Oct 8, 2020

Background

In #1480, we came up with several code examples that can replace prior use of first and last names.

To keep the scope of a pull request small, we made changes to the release directory only. (The release corresponds to the most recent Ember version.) We can now backport the changes to v3.15.0-v3.20.0.

TODOs

  • Study the code changes from https://github.com/ember-learn/guides-source/pull/1530/files.

    Although the pull request changed 8 files, you will only change 7 files. Please do NOT update components/built-in-components.md, as this file will be changed entirely in another issue for Hacktoberfest.

  • Apply the same changes to the respective files in these directories (7 files per directory):

    • guides/v3.15.0
    • guides/v3.16.0
    • guides/v3.17.0
    • guides/v3.18.0
    • guides/v3.19.0
    • guides/v3.20.0 (already done)

    I highly encourage you to make 7 commits. Each commit changes 1 file across different versions. (For a backport issue, if you make the same type of small change in a commit, we can more easily review and approve your pull request.)
@ijlee2 ijlee2 added help wanted Extra attention is needed good first issue Good for newcomers Hacktoberfest Issue counts towards Hacktoberfest labels Oct 8, 2020
@ijlee2
Copy link
Member Author

ijlee2 commented Oct 8, 2020

Hi, everyone. To allow more participation, please sign up for only 1 issue (out of 3 related to this backport). Thanks and happy Hacktoberfest!

@fozy81
Copy link
Member

fozy81 commented Oct 10, 2020

@ijlee2 I'd like to give this one a try.

@ijlee2
Copy link
Member Author

ijlee2 commented Oct 10, 2020

@fozy81 Thank you in advance for your help!

@fozy81
Copy link
Member

fozy81 commented Oct 11, 2020

@ijlee2 first of the backports done! Will do four more commits to follow...

@fozy81
Copy link
Member

fozy81 commented Oct 11, 2020

Hi @ijlee2 All done! Hope that looks okay. Let me know if anything needs fixing.

@ijlee2 ijlee2 mentioned this issue Oct 11, 2020
Merged
ijlee2 added a commit that referenced this issue Oct 11, 2020
@fozy81 @ijlee2
Backport updating code examples (Part 1) (#1568)
2a8b204 
* update names backport for v3.19 issue #1553

* update names backport for v3.18 issue #1553

* update names backport for v3.17 issue #1553

* update names backport for v3.16 issue #1553

* update names backport for v3.15 issue #1553

* Update guides/v3.19.0/models/customizing-serializers.md

* fix typo for update names backport for v3.19 issue #1553

Co-authored-by: Tim <[email protected]>
Co-authored-by: Isaac Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fozy81 fozy81

Labels
good first issue Good for newcomers Hacktoberfest Issue counts towards Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Backport updating code examples (Part 1)
2 participants
@fozy81 @ijlee2