Skip to content

Sidebar styling tweaks #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 10, 2023
Merged

Sidebar styling tweaks #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
de65237
add sidebar background color
Aug 2, 2023
f19b2b4
use base font size in toc
Aug 2, 2023
1194f61
fix: white background on mobile
Aug 2, 2023
aba11f0
chore: clean up unused border
Aug 2, 2023
dbc0474
fix: use large font size for mobile
Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions addon/styles/addon.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,6 @@ main {
padding: 0;
}

.sidebar-container > .es-sidebar {
margin: 0;
}

.info-banner-wrapper {
margin: var(--spacing-1);
padding: var(--spacing-1);
Expand Down Expand Up @@ -107,12 +103,12 @@ main {
/* TODO figure out how much of this media query needs to go into the styleguide */
@media (max-width: 844px) {
main .es-sidebar[aria-expanded="true"] {
border: none;
padding: var(--spacing-2);
z-index: 1;
margin-top: var(--spacing-2);
display: flex;
flex-direction: row-reverse;
margin: var(--spacing-2) 0 0 0;
background: var(--color-white);
}

main .es-sidebar-toggle {
Expand Down
16 changes: 11 additions & 5 deletions addon/styles/table-of-contents.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
/* All the .es-sidebar styling should probably move to the ember-styleguide when we agree this is the right thing to do */
.es-sidebar {
border-right: 2px solid var(--color-gray-300);
padding: var(--spacing-4) var(--spacing-4) 0 0;
margin: calc(-1 * var(--spacing-6)) 0 calc(-1 * var(--spacing-6));
padding: var(--spacing-4) var(--spacing-4);
margin-left: calc(-1 * var(--spacing-4));
background-color: var(--color-gray-200);
}

.table-of-contents {
list-style-type: none;
padding-left: 0;
font-size: var(--font-size-lg);
font-size: var(--font-size-base);
font-weight: var(--font-weight-3);
}

.sub-table-of-contents {
padding-left: var(--spacing-1);
font-size: var(--font-size-md);
font-size: var(--font-size-base);
font-weight: var(--font-weight-2);
}

Expand Down Expand Up @@ -59,3 +59,9 @@ li.toc-heading {
li.toc-heading:first-child {
margin-top: 0;
}

@media (max-width: 844px) {
.table-of-contents {
font-size: var(--font-size-lg);
}
}