Skip to content

Ecosystem icons component #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 22, 2020
Merged

Ecosystem icons component #529

merged 2 commits into from
Jan 22, 2020

Conversation

@mansona
Copy link
Member

@mansona mansona commented Jan 19, 2020 •
edited
Loading

Adds an "ecosystem" icons as a component and not just a single image

Fixes #459

@mansona mansona force-pushed the ecosystem-icons-component branch from 5afcd63 to 0ca5ee0 Compare January 19, 2020 12:15
@ember-learn ember-learn deleted a comment from github-actions bot Jan 19, 2020
@mansona mansona mentioned this pull request Jan 19, 2020
Closed
@mansona mansona requested a review from a team January 19, 2020 12:16
@github-actions
Copy link

github-actions bot commented Jan 19, 2020

Files that got Bigger 🚨:

File raw gzip
ember-website.js +1.91 kB +509 B
ember-website.css +74 B +32 B

Files that got Smaller 🎉:

File raw gzip
vendor.js -26.6 kB -2.86 kB

Files that stayed the same size 🤷‍:

File raw gzip
auto-import-fastboot.js 0 B 0 B
ember-website-fastboot.js 0 B 0 B
vendor.css 0 B 0 B

MelSumner
MelSumner requested changes Jan 21, 2020
View reviewed changes
Copy link
Member

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes requested. We should also be able to handle something like this via style guide- can you put in a ticket for that please? Thanks! 👍

@mansona
Copy link
Member Author

mansona commented Jan 21, 2020

@MelSumner I've swapped out the logo as you requested 👍 but I don't know if I agree that we should be able to do something like this with the styleguide 🤔 this is a hyper-specific implementation to allow us to easily drop in a SVG logo with a solid colour background, if we wanted to do something like this generically then we should drop the idea of the SVG logo and custom colour background and just have each logo as an individual SVG.

I think I discussed this with @pichfl as well and I think we agreed that it was too specific to put in the styleguide 🤔 @pichfl can you remember this discussion?

@mansona mansona force-pushed the ecosystem-icons-component branch from 0ca5ee0 to ff394a0 Compare January 21, 2020 11:33
@github-actions
Copy link

github-actions bot commented Jan 21, 2020

Files that got Bigger 🚨:

File raw gzip
ember-website.js +1.9 kB +501 B
ember-website.css +74 B +32 B

Files that got Smaller 🎉:

File raw gzip
vendor.js -28.5 kB -3.64 kB

Files that stayed the same size 🤷‍:

File raw gzip
auto-import-fastboot.js 0 B 0 B
ember-website-fastboot.js 0 B 0 B
vendor.css 0 B 0 B

@MelSumner
Copy link
Member

MelSumner commented Jan 22, 2020

ok. I think this conversation could technically wait until later. Let me double check which images are there.

MelSumner
MelSumner approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MelSumner MelSumner merged commit 9cbebe8 into redesign-rfc Jan 22, 2020
@MelSumner MelSumner deleted the ecosystem-icons-component branch January 22, 2020 17:44
@mansona mansona mentioned this pull request Jan 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MelSumner MelSumner MelSumner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mansona @MelSumner