Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ember + Storybook writeup #894

Merged
merged 5 commits into from
Jan 20, 2021
Merged

Conversation

amyrlam
Copy link
Member

@amyrlam amyrlam commented Jan 20, 2021

I also updated the template for Substack, can further update after the next issue.

@gossi sorry this didn't get in last issue, appreciate you sharing the link on GitHub and Discord! Please let me know if you have any feedback on the writeup! I haven't used Storybook much, but am excited to explore it more.

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Jan 20, 2021
@amyrlam amyrlam requested a review from a team January 20, 2021 05:33
Copy link
Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉

@amyrlam
Copy link
Member Author

amyrlam commented Jan 20, 2021

thanks @ijlee2 @gossi! we can make edits upstream if needed as well!

also i will get the new email provider substack draft started, since we can have richer content than the blog

@amyrlam amyrlam merged commit b5cba02 into blog/embertimes-172 Jan 20, 2021
@amyrlam amyrlam deleted the amy/embertimes-172 branch January 20, 2021 18:40
@gossi
Copy link

gossi commented Jan 20, 2021

Thanks @amyrlam and @ijlee2. I fine with both of what you wrote. More than I asked for, super happy ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants