Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog(embertimes171): understanding args glimmer #874

Merged
merged 5 commits into from
Jan 4, 2021
Merged

blog(embertimes171): understanding args glimmer #874

merged 5 commits into from
Jan 4, 2021

Conversation

chrisrng
Copy link
Member

@chrisrng chrisrng commented Jan 3, 2021

No description provided.

@chrisrng chrisrng requested a review from a team January 3, 2021 17:39
ijlee2
ijlee2 approved these changes Jan 3, 2021
View reviewed changes
Copy link
Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the early and great write-up!

@ijlee2 ijlee2 merged commit aff2a79 into blog/embertimes-171 Jan 4, 2021
@ijlee2 ijlee2 deleted the chrisrng-patch-1 branch January 4, 2021 05:09
@amyrlam
Copy link
Member

amyrlam commented Jan 5, 2021

thank you both and happy new year! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijlee2 ijlee2 ijlee2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisrng @amyrlam @ijlee2