-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ember times template #849
Conversation
- Fix typo - Add date - Change tag to ember-times (could do thruout if ok) - Remove READMORE
@@ -2,18 +2,17 @@ | |||
title: The Ember Times - Issue No. XXS | |||
author: | |||
- the-crowd # replace with real authors from the author folder (add yourself if you're not there) | |||
date: 2021-XX-XXT00:00:00.000Z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the date format ok? Always prefix T00:00:00.000Z
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. I think we can use https://raw.githubusercontent.com/ember-learn/ember-blog/master/content/the-ember-times-issue-170.md as a template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for working on updating the template!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! sorry I missed some of the finer points in this one 🙈
@mansona no apologies needed, thanks for all of your hard work! |
What it does
Fix typo
Add date
Change tag to ember-times (could do thruout if ok)Remove READMORE
Add 2021 tag
Rebase The Ember Times No. 171 - January 15th 2021 #848 after this is merged