Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember times template #849

Merged
merged 8 commits into from
Dec 21, 2020
Merged

Update ember times template #849

merged 8 commits into from
Dec 21, 2020

Conversation

amyrlam
Copy link
Member

@amyrlam amyrlam commented Dec 21, 2020

What it does

- Fix typo
- Add date
- Change tag to ember-times (could do thruout if ok)
- Remove READMORE
@amyrlam amyrlam requested a review from mansona December 21, 2020 16:37
@@ -2,18 +2,17 @@
title: The Ember Times - Issue No. XXS
author:
- the-crowd # replace with real authors from the author folder (add yourself if you're not there)
date: 2021-XX-XXT00:00:00.000Z
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the date format ok? Always prefix T00:00:00.000Z?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for working on updating the template!

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! sorry I missed some of the finer points in this one 🙈

@ijlee2 ijlee2 merged commit 8d8175a into master Dec 21, 2020
@ijlee2 ijlee2 deleted the chore/update-times-template branch December 21, 2020 18:16
@amyrlam
Copy link
Member Author

amyrlam commented Dec 21, 2020

@mansona no apologies needed, thanks for all of your hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants