Add writeup on Ember performance tweaks #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijlee2
reviewed
May 14, 2020
ijlee2
approved these changes
May 14, 2020
There was a problem hiding this comment.
Looks good to me! I think we (whoever takes it) can cover the 2nd part of Abhilash's performance series after your quote in the end. For example,
> The smaller the page assets, the faster it is for the user to view them. The faster it is for the user to view the page with text and UI, the greater trust they have on our apps/websites.
But wait, there's more! ...
|
@jayjayjpg Sounds good. Feel free to cover the 2nd part, thanks! |
Co-authored-by: Isaac Lee <[email protected]>
|
thank you both! @jayjayjpg @ijlee2 |
|
Hi @amyrlam, What you have shared is correct 👍 |
|
Thank you both @jayjayjpg and @ijlee2 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@abhilashlr wanted to check that you prefer to be called by
Abhilash LRand your pronoun ishe/him? let me know!great post! 💫